Commit Graph

72345 Commits

Author SHA1 Message Date
Martin Trigaux 096fe8a05c [FIX] project: restrict access to dashboard only to project users
Users not belonging to the project user group can not access the model
project.task.history.cumulative
Hide the dashboard for them

Fixes #8606
Closes #8607
2015-10-07 11:19:58 +02:00
Martin Trigaux 35b9ff7146 [FIX] auth_signup: do not send email to duplicated user
When duplicating a user, an email was sent to a user at the email of the
previous user (as the create is called before changing the email).

Closes #8754
2015-10-02 16:32:55 +02:00
Nicolas Martinelli acb55e321d [FIX] mail: reload only in log after composer
Commit e0c1f54fd7 was supposed to prevent the message fetch in the
inbox view. However, self.is_log refers to the type of message: internal
note or message. This properly checks if the page displayed is the inbox
view before fetching the messages.

Related to #7596
opw-650208
2015-10-01 15:34:58 +02:00
Goffin Simon 2b13234661 [FIX] mrp_operarations: str time comparaison
Format error when comparing str time

opw:648349
2015-10-01 15:05:47 +02:00
Odoo Translation Bot 78450f2769 [I18N] Update translation terms from Transifex 2015-10-01 00:32:02 +02:00
Laetitia Gangloff f9859c510c [FIX] stock: compute stock valuation with right quantity
`qty` is the quantity in the product default uom.

`move.price_unit` is the price unit of the product
in this move, for the specific uom of this move.
The quantity to use is therefore the quantity
in the move uom, `move.product_qty`

Closes #4555
2015-09-30 14:47:53 +02:00
Ronald Portier (Therp BV) 65d4b25565 [FIX] tools: i18n_extra loading, backport of 7c2795ca
In case of different directory for stroing po and pot files than 'i18n'
(e.g. 'i18n_extra'), a po could be linked to a wrong pot file.
Use the same folder as the po file to look for pot.
Closes #4323
2015-09-28 15:38:39 +02:00
Christophe Simonis 117b636d3f [FIX] mail: catch database errors when sending mails 2015-09-25 14:43:00 +02:00
Alexis de Lattre fc11b58239 [FIX] stock: service lines duplication when grouping DO invoices
This is possible that changes happen
during the loop in the multiple pickings:
an update in a picking could update another
picking. The browse must therefore be done
inside the loop to update the pickings with
the latest changes.

Fixes #4201
2015-09-25 12:25:52 +02:00
Pierre Verkest be33912a25 [FIX] report_webkit: get webkit path as SUPERUSER_ID
`ir.config_parameter` is readable by employees only.
It could happen to print a webkit report
as a portal / public user.

Closes #4181
2015-09-24 18:11:42 +02:00
Laetitia Gangloff 34f79f3de7 [FIX] purchase_double_validation: do not update limit on module update
In the module `purchase_double_validation`,
you can change the limit to require a second approval
in the purchase settings.

If the module was updated, the limit was re-set to
its default value.

Closes #4183
2015-09-24 17:59:52 +02:00
Laetitia Gangloff 273114204f [FIX] note: `Use fancy note` was re-checked on update
Set security group as not updatable. To be able to not use fancy note

Closes #4178
2015-09-24 16:41:10 +02:00
Valencia Rodrigues Sah c2aff4772e [FIX] product: default value on required field
The qty fields has become computed in 6.1, and the value set by the user is on
min_qty. Set default value as it is required.

Closes #8561
2015-09-17 17:45:20 +02:00
dufresnedavid cc9113f818 [IMP] Prevent unclosed cursor during tests
If an error happens in an overload of setUp, the already-open cursor
is likely not to get properly released before the next test,
deadlocking the db, because tearDown only runs if setUp has
succesfully completed.

Cleanups were added specifically to run every time, after tearDown has
(potentially) been executed.

closes #8327

Note: cleanups run in LIFO order (as they should).
2015-09-17 12:23:09 +02:00
Goffin Simon acf22b7bc8 [FIX] resource: current_hour in interval_get_multi
The minutes of dt_from(start date) must be taken into account by current_hour and not by
todo (hours).
2015-09-14 15:53:59 +02:00
Goffin Simon 2442fe2e4b [FIX] resource: hour_to and hour_from in interval_get_multi
The function interval_get_multi must take into account the minutes in
hour_from and hour_to. hour_to and hour_from are float fields in the model
"resource.calendar.attendance" and the decimal part of these two fields is
for the minutes.

opw:648349
2015-09-14 14:53:14 +02:00
Christophe Simonis a7ff1104bc [FIX] base: sanitize module description 2015-09-11 14:58:44 +02:00
Martin Trigaux 909e6e300a [FIX] email_template: use valid email_from content
Correctly use the email_from tag from template.
This partially reverts commit 0f82346167.
"[FIX] email_template: keep email_from and outgoing server"
Remove the email_from part that was incorrect, keeping the one on mail_server_id

Instead of assigning an non-evaulated email_from in the context, specify the
email_from in the onchange method. This way the created email has an evaulated
from value. This was an issue for templates using email_from like
"${(object.user_id.email or '')|safe}"

In the _notify method method, the email_from is partially respected as it will
be used a fallback only. However changing that would introduce a modification of
behaviour not suitable for 7.0 branch.

Fixes #8409
2015-09-08 14:30:37 +02:00
Goffin Simon bbd15cdca6 [FIX] resource: interval_get_multi
To compute the intervals of working time, the function interval_get_multi
used 'hour_to' and 'hour_from' from "resource.calendar.attendance" model. 'hour_to'
and 'hour_from' are not in UTC timezone. All the dates in odoo are compared in UTC.
Then 'hour_to' and 'hour_from' must be converted.
To take into account the minutes in this computation, the minutes from the start date
are added in the variable todo (number of working hours).

opw:648349
2015-09-08 10:08:45 +02:00
Paul Catinean 20f69bbce9 [FIX] res.users: remove check_super duplication
Closes #8403
2015-09-07 11:07:43 +02:00
Matthieu Dietrich 1cfe1910db [FIX] account: Remove superfluous bracket for analytic account domain
With the bracket in place,
the domain does not consider the last part,
"('state','not in',('close','cancelled'))".

Closes #3714
2015-09-02 14:10:19 +02:00
Thomas Rehn 0fb00808b2 [FIX] account_bank_statement_extensions: lines confirmation
Confirm lines of account cash statement on closing

The `account_bank_statement_extensions` adds
a state field to account.bank.statement.line
and sets the status to 'confirm'
when a bank statement is closed.

When a cash statement is closed,
the lines remained in draft.

Closes #3584
2015-09-01 12:41:20 +02:00
Commandant Custo f26df86ea9 [FIX] portal_sale: fix default domains
Quotations/Sales orders menu in the portal must copy the behavior
of the menus in the regular back-end.
Backport of e5c5b1cc23

closes #8271
opw:648186
2015-09-01 09:58:41 +02:00
Nicolas Lempereur 411a07a64e [FIX] web: enable default_focus on html field
closes #8244
opw-647578
2015-08-27 13:20:41 +02:00
Laetitia Gangloff 607114ff00 [FIX] stock: Scheduled / Max. Expected date change on picking when changed in its moves
When changing the min_date / max_date in a move,
the date change wasn't propagated to its picking.

The use of store triggers is needed in such a case,
`store=True` isn't enough

Fixes #1862
Closes #3278
2015-08-17 18:04:13 +02:00
Maxime Chambreuil b541187345 [FIX] l10n_ca: no attempt to re-create input/output accounts properties
Deleting the properties for the default accounts
in the root product category and then
updating the l10n_ca module leaded to a crash
due to the fact the module tried to re-create
the properties as they were no longer there.

Fixes #3130
Closes #3131
2015-08-17 16:44:09 +02:00
Christophe Combelles 11cd8ba06c [FIX] web_kanban: access gravatar with current scheme
When Odoo is accessed in https, inserting the gravatar
image using the http protocol leads to a security
alert in most browsers.

Closes #3042
2015-08-14 15:35:48 +02:00
Denis Ledoux d98ac716c1 [FIX] account: account type of account created on bank account creation
When creating a new bank account
e.g. Accounting > Configuration > Accounts >
Setup your Bank Accounts

When the user leaves the journal blank,
a journal, and an account associated to this
journal, are automatically created.

The account type of the account created could be wrong,
as it used the account type of the parent of the first
account of internal type `Liquidity`, which
could not be an account of account type Cash or Bank, but of
account type 'View', and such an account type does not
have the right delivery forward method, in order to report
correctly the amounts when closing a fiscal year.

Instead of using the account type of the parent,
it should actually uses the account type of the sibbling,
which have a correct delivery forward method

opw-647311
2015-08-14 10:46:05 +02:00
Thomas Rehn 937b9575c0 [FIX] account: check for profit/loss accounts
in method `button_confirm_cash` of `account.cash.statement`

The check was verifying that the profit/loss account
was set on the journal, and if it was, it raised that it
wasn't, which is obviously wrong.

This was solved in Odoo 8.0 by replacing the code
by something more readable in 9dc9169, and the same
logic to check that the profit/loss accounts are
set is still there.

Closes #2924
2015-08-13 12:04:28 +02:00
Denis Ledoux 85b2e607bf [FIX] crm: prevent use a sales tag from another team.
On the `categ_ids` fields definition on `crm.lead`,
a domain has been added in order to prevent
the use of a sales tag belonging to another
sales team.

As the domain was overidden in the form views,
with a different domain, it was allowed
to use a sales tag from another sales team.

Besides, the domain applied in the form views,
`[('object_id.model','=','crm.lead')]`
is included in the domain applied in the fiel
definition.

Closes #2898
2015-08-12 17:36:14 +02:00
Goffin Simon 528c15cc7b [FIX] account_analytic_plans: creating an analytic distribution
When creating an analytic distribution, the field "plan_id" must be required.

opw:646788
2015-08-12 13:32:28 +02:00
Nicolas Martinelli 8f96a13855 [FIX] mrp_repair: typo correction
"Fals" instead of "False"
2015-08-12 11:19:42 +02:00
Wolfgang Taferner f41026631f [FIX] account: add missing onchange attribute for payment term computation
Fixes #5118
Closes #7777
2015-08-11 10:36:04 +02:00
Goffin Simon 4a46ca474d [FIX] sale: comment in partial invoice
When a partial invoice is created from a sale order, the field "note"
in the sale order must be written in the field "comment" of the invoice.

opw:646852
2015-08-07 15:19:01 +02:00
Olivier Dony da8855ad2b [FIX] auth_openid: typo in rev. 77868ec 2015-08-07 14:17:42 +02:00
Olivier Dony 5e4c09ae53 [FIX] res.users: more consistent handling of user private fields 2015-08-07 13:15:45 +02:00
Goffin Simon 39b0a4c2cc [FIX] account: tax_sign
When changing manually the amount of tax in supplier invoice,
the tax sign of the tax must be kept.
Back-port of 4f6eebf698

opw:645691
2015-08-07 11:50:34 +02:00
Olivier Dony 77868ec4f9 [FIX] base, auth_openid: wrong implementation of API by auth_openid
Authentication modules are supposed to override res_users.check_credentials()
in order to plug in their own mechanism, without actually modifying the
behavior of res_users.check(), res_users.authenticate() or
res_users._login().

auth_openid was incorrectly overriding check() instead of
check_credentials(), and unnecessarily accessing private
attributes of res_users. Fixing the implementation of auth_openid
to follow the API means we can completely make those attributes
private.
2015-08-06 19:21:12 +02:00
Olivier Dony d2d81ca9d8 [FIX] crm_partner_assign: search_geo_partner() should not pick deactivated partners 2015-08-06 09:20:24 +02:00
Daniel Reis 8b3d69a0d7 [FIX] orm: performance of regex to check search `order` spec
This regex is used for a quick sanity check of
the order_spec in `search(order=<order_spec>)`.
Because it was build on the repetition of a
group ending with a series of optional patterns,
it could cause expensive backtracking when the
order spec did not actually match the regex
(the regex engine was trying all possible ways
to split the groups)

Forcing the repeating group to either end
with a comma or the end of the string prevents
prohibitive backtracking, while being even
more restrictive with regard to the syntax of
the order spec.

Closes #7755
2015-08-04 11:45:01 +02:00
Martin Trigaux 180b2e7746 [I18N] Transifex project URL
Thank you Transifex to change the URL scheme from time to time, that's cool.
cf https://www.transifex.com/blog/2015/new-url-schema/
2015-08-03 17:25:44 +02:00
Odoo Translation Bot 389252dd95 [I18N] Update translation terms from Transifex 2015-08-02 08:30:05 +02:00
Matthieu Dietrich 54a477d797 [FIX] fetchmail: socket timeout
Add a 60s timeout to fetchmail connections.

Closes #7790
2015-08-01 17:31:49 +02:00
Goffin Simon f10c03ac68 [FIX] sale: onchange task_work
The unticked option in Sales settings "Prepare invoices based on task's activities"  doesn't
have to uninstall the options "Record timesheet lines per tasks" and "Generate tasks from sale orders"
in Project settings.
When "Prepare invoices based on task's activities" is unticked, this fix avoid to uninstall these options each
time we go to Sales settings because "onchange_task_work" is triggered each time we go to Sales settings.

opw:645833
2015-07-31 08:48:12 +02:00
Olivier Dony b4de311b0c [FIX] auth_crypt: use system random number generator
Switch to system random as number generator instead of the
default PRNG, which is not recommended for generating
security-related values such as unique tokens.

(Complements parent commit)

Closes #7761
2015-07-29 13:49:11 +02:00
Colin Newell 93f5f86afd [FIX] auth_signup, event_moodle, pad, share, survey: use system random number generator
Switch to system random as number generator instead of the
default PRNG, which is not recommended for generating
security-related values such as unique tokens.

Closes #7761
2015-07-29 12:40:31 +02:00
Wolfgang Taferner 52edf789c2 [FIX] auth_crypt: safer import of base module
Commit 856bc6f2b1
may cause an issue if the auth_crypt module
is loaded before the base module. That should never
happen in normal circumstances, but forcing an
explicit import does not hurt and makes it safer.

Closes #6742
2015-07-29 12:19:55 +02:00
Christophe Simonis cb29f9efac [FIX] base: reset `latest_version` field when uninstalling a module. 2015-07-29 12:00:15 +02:00
Jusab Sida 034f540664 [IMP] crm, base_calendar: help messages on the
active field were misleading. Actually, not really misleading, just
wrong. Because the behavior is the opposite of what the help tells.
2015-07-28 18:27:39 +02:00
Nicolas Lempereur 0e151f7f32 [FIX] web_view_editor: javascript errors
A jquery selector $('td[id^=]') may have been valid once uppon a time,
but it cause error on current jquery versions.

Also in some case when we want to add a field on a view, there may be
a mess to detect the parent.

opw-645557
2015-07-23 15:48:53 +02:00