odoo
/
odoo
2
0
Fork 0
Code Pull Requests Releases Activity

[FIX] stock: service lines duplication when grouping DO invoices 

This is possible that changes happen
during the loop in the multiple pickings:
an update in a picking could update another
picking. The browse must therefore be done
inside the loop to update the pickings with
the latest changes.

Fixes #4201
This commit is contained in:
Alexis de Lattre 2014-12-12 12:21:35 +01:00 committed by Denis Ledoux
parent be33912a25
commit fc11b58239
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
addons/stock/stock.py
View File

@ -1132,7 +1132,9 @@ class stock_picking(osv.osv):
invoices_group = {}
res = {}
inv_type = type
for picking in self.browse(cr, uid, ids, context=context):
for picking_id in ids:
# The browse inside the loop is done on purpose, as a change in the pickings during the loop is possible
picking = self.browse(cr, uid, picking_id, context=context)
if picking.invoice_state != '2binvoiced':
continue
partner = self._get_partner_to_invoice(cr, uid, picking, context=context)