Commit Graph

72318 Commits

Author SHA1 Message Date
Denis Ledoux d98ac716c1 [FIX] account: account type of account created on bank account creation
When creating a new bank account
e.g. Accounting > Configuration > Accounts >
Setup your Bank Accounts

When the user leaves the journal blank,
a journal, and an account associated to this
journal, are automatically created.

The account type of the account created could be wrong,
as it used the account type of the parent of the first
account of internal type `Liquidity`, which
could not be an account of account type Cash or Bank, but of
account type 'View', and such an account type does not
have the right delivery forward method, in order to report
correctly the amounts when closing a fiscal year.

Instead of using the account type of the parent,
it should actually uses the account type of the sibbling,
which have a correct delivery forward method

opw-647311
2015-08-14 10:46:05 +02:00
Thomas Rehn 937b9575c0 [FIX] account: check for profit/loss accounts
in method `button_confirm_cash` of `account.cash.statement`

The check was verifying that the profit/loss account
was set on the journal, and if it was, it raised that it
wasn't, which is obviously wrong.

This was solved in Odoo 8.0 by replacing the code
by something more readable in 9dc9169, and the same
logic to check that the profit/loss accounts are
set is still there.

Closes #2924
2015-08-13 12:04:28 +02:00
Denis Ledoux 85b2e607bf [FIX] crm: prevent use a sales tag from another team.
On the `categ_ids` fields definition on `crm.lead`,
a domain has been added in order to prevent
the use of a sales tag belonging to another
sales team.

As the domain was overidden in the form views,
with a different domain, it was allowed
to use a sales tag from another sales team.

Besides, the domain applied in the form views,
`[('object_id.model','=','crm.lead')]`
is included in the domain applied in the fiel
definition.

Closes #2898
2015-08-12 17:36:14 +02:00
Goffin Simon 528c15cc7b [FIX] account_analytic_plans: creating an analytic distribution
When creating an analytic distribution, the field "plan_id" must be required.

opw:646788
2015-08-12 13:32:28 +02:00
Nicolas Martinelli 8f96a13855 [FIX] mrp_repair: typo correction
"Fals" instead of "False"
2015-08-12 11:19:42 +02:00
Wolfgang Taferner f41026631f [FIX] account: add missing onchange attribute for payment term computation
Fixes #5118
Closes #7777
2015-08-11 10:36:04 +02:00
Goffin Simon 4a46ca474d [FIX] sale: comment in partial invoice
When a partial invoice is created from a sale order, the field "note"
in the sale order must be written in the field "comment" of the invoice.

opw:646852
2015-08-07 15:19:01 +02:00
Olivier Dony da8855ad2b [FIX] auth_openid: typo in rev. 77868ec 2015-08-07 14:17:42 +02:00
Olivier Dony 5e4c09ae53 [FIX] res.users: more consistent handling of user private fields 2015-08-07 13:15:45 +02:00
Goffin Simon 39b0a4c2cc [FIX] account: tax_sign
When changing manually the amount of tax in supplier invoice,
the tax sign of the tax must be kept.
Back-port of 4f6eebf698

opw:645691
2015-08-07 11:50:34 +02:00
Olivier Dony 77868ec4f9 [FIX] base, auth_openid: wrong implementation of API by auth_openid
Authentication modules are supposed to override res_users.check_credentials()
in order to plug in their own mechanism, without actually modifying the
behavior of res_users.check(), res_users.authenticate() or
res_users._login().

auth_openid was incorrectly overriding check() instead of
check_credentials(), and unnecessarily accessing private
attributes of res_users. Fixing the implementation of auth_openid
to follow the API means we can completely make those attributes
private.
2015-08-06 19:21:12 +02:00
Olivier Dony d2d81ca9d8 [FIX] crm_partner_assign: search_geo_partner() should not pick deactivated partners 2015-08-06 09:20:24 +02:00
Daniel Reis 8b3d69a0d7 [FIX] orm: performance of regex to check search `order` spec
This regex is used for a quick sanity check of
the order_spec in `search(order=<order_spec>)`.
Because it was build on the repetition of a
group ending with a series of optional patterns,
it could cause expensive backtracking when the
order spec did not actually match the regex
(the regex engine was trying all possible ways
to split the groups)

Forcing the repeating group to either end
with a comma or the end of the string prevents
prohibitive backtracking, while being even
more restrictive with regard to the syntax of
the order spec.

Closes #7755
2015-08-04 11:45:01 +02:00
Martin Trigaux 180b2e7746 [I18N] Transifex project URL
Thank you Transifex to change the URL scheme from time to time, that's cool.
cf https://www.transifex.com/blog/2015/new-url-schema/
2015-08-03 17:25:44 +02:00
Odoo Translation Bot 389252dd95 [I18N] Update translation terms from Transifex 2015-08-02 08:30:05 +02:00
Matthieu Dietrich 54a477d797 [FIX] fetchmail: socket timeout
Add a 60s timeout to fetchmail connections.

Closes #7790
2015-08-01 17:31:49 +02:00
Goffin Simon f10c03ac68 [FIX] sale: onchange task_work
The unticked option in Sales settings "Prepare invoices based on task's activities"  doesn't
have to uninstall the options "Record timesheet lines per tasks" and "Generate tasks from sale orders"
in Project settings.
When "Prepare invoices based on task's activities" is unticked, this fix avoid to uninstall these options each
time we go to Sales settings because "onchange_task_work" is triggered each time we go to Sales settings.

opw:645833
2015-07-31 08:48:12 +02:00
Olivier Dony b4de311b0c [FIX] auth_crypt: use system random number generator
Switch to system random as number generator instead of the
default PRNG, which is not recommended for generating
security-related values such as unique tokens.

(Complements parent commit)

Closes #7761
2015-07-29 13:49:11 +02:00
Colin Newell 93f5f86afd [FIX] auth_signup, event_moodle, pad, share, survey: use system random number generator
Switch to system random as number generator instead of the
default PRNG, which is not recommended for generating
security-related values such as unique tokens.

Closes #7761
2015-07-29 12:40:31 +02:00
Wolfgang Taferner 52edf789c2 [FIX] auth_crypt: safer import of base module
Commit 856bc6f2b1
may cause an issue if the auth_crypt module
is loaded before the base module. That should never
happen in normal circumstances, but forcing an
explicit import does not hurt and makes it safer.

Closes #6742
2015-07-29 12:19:55 +02:00
Christophe Simonis cb29f9efac [FIX] base: reset `latest_version` field when uninstalling a module. 2015-07-29 12:00:15 +02:00
Jusab Sida 034f540664 [IMP] crm, base_calendar: help messages on the
active field were misleading. Actually, not really misleading, just
wrong. Because the behavior is the opposite of what the help tells.
2015-07-28 18:27:39 +02:00
Nicolas Lempereur 0e151f7f32 [FIX] web_view_editor: javascript errors
A jquery selector $('td[id^=]') may have been valid once uppon a time,
but it cause error on current jquery versions.

Also in some case when we want to add a field on a view, there may be
a mess to detect the parent.

opw-645557
2015-07-23 15:48:53 +02:00
Nicolas Lempereur c0bf28534e [FIX] crm_claim: wrong many2one on claims report
The field used for the report was different than the field used on the
model the report is based uppon.

As analyzed by jle.

opw-645582
2015-07-23 11:04:13 +02:00
Nicolas Lempereur e0c1f54fd7 [FIX] mail: reload only in log after composer
The commit 312b85e added a reloading of the chatter messages after
closing the mail composer. But e.g in Messaging > Inbox a simple reload
isn't enough. For now this commit restrict the reload to chatter logs
(e.g the chatter of a quotation).

related to PR #7596
2015-07-16 08:16:36 +02:00
Simon Lejeune e9403a7ab7 [FIX] packaging: tarball nightly test
This reverts commit 5bbcc14d2f and allow
to use the pil from debian's "python-pil" by telling pip to not install
the dependencies
2015-07-15 15:34:14 +02:00
Olivier Dony 8ea4bf81f7 [FIX] fetchmail: workaround poplib line length bug
In order to fix Python bug https://bugs.python.org/issue16041
a maximum line length was introduced in poplib when reading
email contents from the POP3 server.
That limit is set to prevent DoS attacks via malicious POP3
servers.

The default limit (2048) seems to be too low for emails
commonly found on the internet, retrieved via POP3 from
popular mail services such as GMail, Hotmail, etc.
(The POP3 servers might send back the lines verbatim
without splitting them up)

This is discussed in follow-up Python bug
https://bugs.python.org/issue23906.

Workaround implemented by forcing a higher default limit
to accomodate POP3 responses with lines up to 64KB.
2015-07-15 14:18:09 +02:00
Simon Lejeune 5bbcc14d2f [FIX] packaging: tarball nightly test
PIL is no more en pypi. Use the external provider.
2015-07-15 12:03:23 +02:00
Simon Lejeune 94e2d99283 [FIX] packaging: remove policy-rc configuration
It was preventing postgresql to generate a working cluster.
2015-07-14 19:15:25 +02:00
Christophe Simonis be6c7582a0 [FIX] package.py: search for prompt correctly. 2015-07-14 15:08:14 +02:00
Olivier LAURENT e12cecea9d [FIX] tools: separator in po comments
Comments in .po(t) files for translations of type "code" (e.g. field labels)
specify the path to the file containing the translation. This path should be
OS-independent to get the same result whatever the plateform the instance is
running on.
Closes #7561
2015-07-14 11:40:16 +02:00
Nicolas Lempereur 312b85ee2a [FIX] mail: reload messages after closing composer
Always reload the message after the mail composer message is closed.

Since there is several unrelated model it would probably messy to go
from the mail thread to the mail composer popup to see if a new message
is posted (or get it and add it in the chatter like done in the simple
message editor).

With this change, anytime the mail composer modal is closed the mail
thread messages are reloaded.

closes #7596
opw-644406
2015-07-14 10:43:33 +02:00
Denis Ledoux 89e1aae508 [FIX] base_action_rule: using relativedelta instead of timedelta
For the simple reason that `months` isn't an accepted argument
of `timedelta`
2015-07-10 17:18:37 +02:00
Sandy Carter 1d0187223b [FIX] auth_oauth_signup: Factor out user signup values
There is no easy way to edit the values sent
to newly generated users from oauth_signup.

In some cases,
the mapping from an oauth provider can be different.
* ex: login is something other than email

In other cases,
there are additional fields in res_users added by a module
* ex: firstname and last name in `partner_firstname`

This factorization allows modules inheriting from `auth_oauth_signup`
to alter values sent to the copy of Template User.
This means smaller changes to the default behaviour
and the ability to properly inherit
(multiple times if needed)
this module without losing needed behaviour.

Closes #2355
2015-07-09 16:39:53 +02:00
Jose J. Duran 23cb6ef7df [FIX] account_asset: missing named arguments in signature
Otherwise the context of original method is lost.
2015-07-09 16:01:35 +02:00
Nicolas Martinelli a4ef73fb09 [FIX] mrp: merge lines where products to consume are identical
Method action_produce does not support the case where the same product appears
on multiple lines. We do this to avoid major changes in a stable version.

opw-644093
2015-07-09 11:11:01 +02:00
Guewen Baconnier 4fe0c6bd60 [IMP] account: updated index to optimize _default_get of account.move.line
A log analysis showed that the normalized query below was executed very often
with a slow explain plan using a seq scan.

```sql

SELECT move_id, date
FROM account_move_line
WHERE journal_id = <journal_id>
AND period_id = <period_id>
AND create_uid = <user_id>
AND state = 'draft'
ORDER BY id DESC LIMIT 0;

```

This query is called in the _default_get of account.move.line to find the last
unbalanced move line.

The existing index can be improved to cover this query as well, showing an
impressive improvement of the explain plan as explained here:
https://github.com/odoo/odoo/pull/7430#issuecomment-119521031

Closes #7430
2015-07-08 13:56:20 +02:00
Guewen Baconnier 166839fb46 [FIX] l10n_ch: Link the taxes to the correct accounts
Fixes #4288
Closes #4300
2015-07-08 13:40:50 +02:00
Temur Vibliani 0eeab361d9 [FIX] tools: Added Georgian Language to the installable languages 2015-07-08 11:51:35 +02:00
Martin Trigaux 3add4f665c [FIX] tools: accept multilines on_change
Allow to write on_change on several lines (accepted by view parser but was not
by yaml parser, making false positive at 595216b)
2015-07-07 15:36:15 +02:00
Nicolas Martinelli 9fa7624e25 [FIX] stock: onchange_quantity and onchange_uos_quantity use rounding
It is necessary to round the quantities with the appropriate precision. Indeed,
since onchange_quantity and onchange_uos_quantity trigger each other indirectly,
it is quite easy to fall in an infinite loop if the uom and uos precisions are
different.

Follows commit 6e346f0adb

opw-643651
2015-07-07 11:25:19 +02:00
Loïc BELLIER 34b9f43011 [FIX] stock: add location in context on prodlot search
To be consistant with the results of _get_stock. Otherwise search made on
stock_available may not display results with the same value than the search
criteria.
Fixes #3976
2015-07-06 14:41:56 +02:00
Nicolas Martinelli 6e346f0adb [FIX] stock: product_uos_qty must have the precision of Product UoS
If 'Product UoS' has a higher precision than 'Product Unit of Measure', the
method onchange_uos_quantity will be called over and over by an infinite loop
if 'product_uos_qty' doesn't have the sufficient number of decimals.

opw-643651
2015-07-03 16:42:34 +02:00
Nicolas Martinelli 2a49c1a7fb [FIX] purchase: take into account the currency of unit price
The currency of the unit price of the stock.move is the currency of the
company, which can be different from the currency of the invoice.

opw-643077
2015-07-03 12:26:02 +02:00
Lorenzo Battistini 0f82346167 [FIX] email_template: keep email_from and outgoing server
When sending an email from mail.compose.message using a template, the system
should use the outgoing mail server associated to the template.
Introduce context hack to keep these values.

This should NOT to be forward ported to version 8 where a proper fix exists.

Fixes #3848
2015-07-03 12:21:53 +02:00
Olivier Dony dc0e126b53 [FIX] hr_holidays: leave holiday overlap should ignore cancelled/refused ones
Obviously a cancelled leave does not really
overlap with a new one.

bzr revid: odo@openerp.com-20131023162928-56vdsjxr8sa4n3jv

Closes #2329
2015-07-03 12:07:47 +02:00
Christophe Combelles 2c37f83435 [FIX] analytic: duplication of analytic lines
When duplicating analytic accounts, child accounts are duplicated as well.
The custom copy method removes the analytic lines but this applies only on the
first copy. As the copy_data method recursively copies child accounts, these
child accounts did not use the custom copy method but the basic copy_data.

Move to copy_data

Fixes #6368, lp:1149676
2015-07-02 16:54:46 +02:00
Anaël Closson 6af7c636c2 [FIX] sale: cannot filter on paid = False
Closes #2211
2015-07-02 15:15:25 +02:00
Matthieu Dietrich f2c807d99d [IMP] account_report_company: performance on partner name_search
The field display_name is present in account_report_company but not in base
on the res.partner (has been added in v8 in base).
Create a hook method to keep using the slow CASE in base and switch to the
faster display_name when installing account_report_company.
2015-07-02 14:10:23 +02:00
Odoo Translation Bot 2326bb7a54 [I18N] Update translation terms from Transifex 2015-07-01 10:45:16 +02:00