[FIX] base_import_module: allow selective access to module files
As a consequence of rev. 76cd8d2558d2a1fc11681dbc4a134ba06fb698c0, imported modules were unable to access their resource files during import. Rather than further modifying the file_open API to whitelist paths (the whole thing needs a redesign in master), we temporarily whitelist the temporary directory by including it in the global addons_paths, making sure to undo it afterwards. This gives all lower level function access the resource files via file_open, without having to pass around whitelisted paths through many different calls.
This commit is contained in:
parent
d18d606a55
commit
c6b9b69f6a
|
@ -96,6 +96,9 @@ class view(osv.osv):
|
||||||
raise osv.except_osv(_('Error !'), msg % zf.filename)
|
raise osv.except_osv(_('Error !'), msg % zf.filename)
|
||||||
|
|
||||||
with openerp.tools.osutil.tempdir() as module_dir:
|
with openerp.tools.osutil.tempdir() as module_dir:
|
||||||
|
import openerp.modules as addons
|
||||||
|
try:
|
||||||
|
addons.module.ad_paths.append(module_dir)
|
||||||
z.extractall(module_dir)
|
z.extractall(module_dir)
|
||||||
dirs = [d for d in os.listdir(module_dir) if os.path.isdir(opj(module_dir, d))]
|
dirs = [d for d in os.listdir(module_dir) if os.path.isdir(opj(module_dir, d))]
|
||||||
for mod_name in dirs:
|
for mod_name in dirs:
|
||||||
|
@ -108,6 +111,8 @@ class view(osv.osv):
|
||||||
except Exception, e:
|
except Exception, e:
|
||||||
_logger.exception('Error while importing module')
|
_logger.exception('Error while importing module')
|
||||||
errors[mod_name] = tools.ustr(e)
|
errors[mod_name] = tools.ustr(e)
|
||||||
|
finally:
|
||||||
|
addons.module.ad_paths.remove(module_dir)
|
||||||
r = ["Successfully imported module '%s'" % mod for mod in success]
|
r = ["Successfully imported module '%s'" % mod for mod in success]
|
||||||
for mod, error in errors.items():
|
for mod, error in errors.items():
|
||||||
r.append("Error while importing module '%s': %r" % (mod, error))
|
r.append("Error while importing module '%s': %r" % (mod, error))
|
||||||
|
|
Loading…
Reference in New Issue