45 lines
1.6 KiB
Diff
45 lines
1.6 KiB
Diff
From 5140dcf50322edf0cdf99c17c7f83650a11b20bd Mon Sep 17 00:00:00 2001
|
|
Message-Id: <5140dcf50322edf0cdf99c17c7f83650a11b20bd.1601675152.git.zanussi@kernel.org>
|
|
In-Reply-To: <5b5a156f9808b1acf1205606e03da117214549ea.1601675151.git.zanussi@kernel.org>
|
|
References: <5b5a156f9808b1acf1205606e03da117214549ea.1601675151.git.zanussi@kernel.org>
|
|
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
|
|
Date: Fri, 16 Jun 2017 19:03:16 +0200
|
|
Subject: [PATCH 122/333] net/core: use local_bh_disable() in netif_rx_ni()
|
|
Origin: https://www.kernel.org/pub/linux/kernel/projects/rt/4.19/older/patches-4.19.148-rt64.tar.xz
|
|
|
|
In 2004 netif_rx_ni() gained a preempt_disable() section around
|
|
netif_rx() and its do_softirq() + testing for it. The do_softirq() part
|
|
is required because netif_rx() raises the softirq but does not invoke
|
|
it. The preempt_disable() is required to remain on the same CPU which added the
|
|
skb to the per-CPU list.
|
|
All this can be avoided be putting this into a local_bh_disable()ed
|
|
section. The local_bh_enable() part will invoke do_softirq() if
|
|
required.
|
|
|
|
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
|
|
---
|
|
net/core/dev.c | 6 ++----
|
|
1 file changed, 2 insertions(+), 4 deletions(-)
|
|
|
|
diff --git a/net/core/dev.c b/net/core/dev.c
|
|
index ccedc620795c..414e4d7e2082 100644
|
|
--- a/net/core/dev.c
|
|
+++ b/net/core/dev.c
|
|
@@ -4526,11 +4526,9 @@ int netif_rx_ni(struct sk_buff *skb)
|
|
|
|
trace_netif_rx_ni_entry(skb);
|
|
|
|
- preempt_disable();
|
|
+ local_bh_disable();
|
|
err = netif_rx_internal(skb);
|
|
- if (local_softirq_pending())
|
|
- do_softirq();
|
|
- preempt_enable();
|
|
+ local_bh_enable();
|
|
|
|
return err;
|
|
}
|
|
--
|
|
2.17.1
|
|
|