From 93bcd7fda7c3754ae96ff8d6eec22568964babc4 Mon Sep 17 00:00:00 2001
From: Bostjan Meglic <b.meglic@iskratel.si>
Date: Thu, 15 Jun 2023 09:29:15 +0000
Subject: [PATCH] [SMF] Fix a use-after-free bug

---
 src/smf/nsmf-handler.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/smf/nsmf-handler.c b/src/smf/nsmf-handler.c
index 6df4658c1..edff0cab2 100644
--- a/src/smf/nsmf-handler.c
+++ b/src/smf/nsmf-handler.c
@@ -679,11 +679,11 @@ bool smf_nsmf_handle_update_sm_context(
                     "No PolicyAssociationId", NULL, NULL, NULL);
         }
     } else if (SmContextUpdateData->serving_nf_id) {
-        if (sess->serving_nf_id) {
-            ogs_free(sess->serving_nf_id);
-        }
         ogs_debug("Old serving_nf_id: %s, new serving_nf_id: %s",
             sess->serving_nf_id, SmContextUpdateData->serving_nf_id);
+
+        if (sess->serving_nf_id)
+            ogs_free(sess->serving_nf_id);
         sess->serving_nf_id = ogs_strdup(SmContextUpdateData->serving_nf_id);
         ogs_assert(sess->serving_nf_id);