From 204ac35a667a309ea18d22c6d96ce46b6f60ed1c Mon Sep 17 00:00:00 2001
From: Pau Espin Pedrol <pespin@sysmocom.de>
Date: Mon, 11 Dec 2023 17:20:00 +0100
Subject: [PATCH] gtp/v1: Specify 'MS Validated' IE as uint8

This field is a fixed size 1 byte with all bits set as spare (1) and the
lsb set as 0 ("No") or 1 ("Yes").
---
 lib/gtp/v1/message.c           | 4 ++--
 lib/gtp/v1/message.h           | 4 ++--
 lib/gtp/v1/support/gtp1-tlv.py | 1 +
 3 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/lib/gtp/v1/message.c b/lib/gtp/v1/message.c
index 5dc5746e2..506b12579 100644
--- a/lib/gtp/v1/message.c
+++ b/lib/gtp/v1/message.c
@@ -22,7 +22,7 @@
 /*******************************************************************************
  * This file had been created by gtp1-tlv.py script v0.1.0
  * Please do not modify this file but regenerate it via script.
- * Created on: 2023-08-26 16:35:02.182792 by acetcom
+ * Created on: 2023-12-11 17:18:23.055278 by pespin
  * from 29060-h40.docx
  ******************************************************************************/
 
@@ -129,7 +129,7 @@ ogs_tlv_desc_t ogs_gtp1_tlv_desc_p_tmsi_signature =
 
 ogs_tlv_desc_t ogs_gtp1_tlv_desc_ms_validated =
 {
-    OGS_TV_FIXED_STR,
+    OGS_TV_UINT8,
     "MS Validated",
     OGS_GTP1_MS_VALIDATED_TYPE,
     1,
diff --git a/lib/gtp/v1/message.h b/lib/gtp/v1/message.h
index 7908cece6..743d91a69 100644
--- a/lib/gtp/v1/message.h
+++ b/lib/gtp/v1/message.h
@@ -22,7 +22,7 @@
 /*******************************************************************************
  * This file had been created by gtp1-tlv.py script v0.1.0
  * Please do not modify this file but regenerate it via script.
- * Created on: 2023-08-26 16:35:02.176563 by acetcom
+ * Created on: 2023-12-11 17:18:23.049626 by pespin
  * from 29060-h40.docx
  ******************************************************************************/
 
@@ -470,7 +470,7 @@ typedef ogs_tlv_uint8_t ogs_gtp1_tlv_reordering_required_t;
 typedef ogs_tlv_octet_t ogs_gtp1_tlv_authentication_triplet_t;
 typedef ogs_tlv_octet_t ogs_gtp1_tlv_map_cause_t;
 typedef ogs_tlv_octet_t ogs_gtp1_tlv_p_tmsi_signature_t;
-typedef ogs_tlv_octet_t ogs_gtp1_tlv_ms_validated_t;
+typedef ogs_tlv_uint8_t ogs_gtp1_tlv_ms_validated_t;
 typedef ogs_tlv_uint8_t ogs_gtp1_tlv_recovery_t;
 typedef ogs_tlv_uint8_t ogs_gtp1_tlv_selection_mode_t;
 typedef ogs_tlv_uint32_t ogs_gtp1_tlv_tunnel_endpoint_identifier_data_i_t;
diff --git a/lib/gtp/v1/support/gtp1-tlv.py b/lib/gtp/v1/support/gtp1-tlv.py
index 7e5024781..42f6cd509 100644
--- a/lib/gtp/v1/support/gtp1-tlv.py
+++ b/lib/gtp/v1/support/gtp1-tlv.py
@@ -303,6 +303,7 @@ set_size("MS Time Zone", 2) # Wrongly specified as 1 in spec table
 set_c_type("Cause", 'uint')
 set_c_type("TLLI", 'uint')
 set_c_type("P-TMSI", 'uint')
+set_c_type("MS Validated", 'uint')
 set_c_type("Recovery", 'uint')
 set_c_type("Tunnel Endpoint Identifier Data I", 'uint')
 set_c_type("Tunnel Endpoint Identifier Control Plane", 'uint')