From 12c031032802b8cebc055ed39aea1dd6429145ca Mon Sep 17 00:00:00 2001 From: Gaber Stare Date: Tue, 13 Jun 2023 09:09:55 +0000 Subject: [PATCH] [SMF] Decrease sessions metric on OLD Session Release Since [redesign](https://github.com/open5gs/open5gs/commit/8553c77733f50f82bfa6a9a4ee57f7ca0133a815) of fivegs_smffunction_sm_sessionnbr gauge, the metric doesn't expose some decrements. The decreasing of gauge had been moved out of function stats_remove_smf_session. It should be decreased every time stats_remove_smf_session is called, but this particular case is easily reproducible by killing UPF while the session is established. --- src/smf/context.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/smf/context.c b/src/smf/context.c index 55dbc7917..d371c7ef9 100644 --- a/src/smf/context.c +++ b/src/smf/context.c @@ -1490,6 +1490,8 @@ smf_sess_t *smf_sess_add_by_sbi_message(ogs_sbi_message_t *message) if (sess) { ogs_warn("OLD Session Will Release [SUPI:%s,PDU Session identity:%d]", SmContextCreateData->supi, SmContextCreateData->pdu_session_id); + smf_metrics_inst_by_slice_add(&sess->plmn_id, &sess->s_nssai, + SMF_METR_GAUGE_SM_SESSIONNBR, -1); smf_sess_remove(sess); }