Commit 1ac9bc69 ("sched/tracing: Add a new tracepoint for sleeptime")
added a new sched:sched_stat_sleeptime tracepoint.
It's broken: the first sample we get on a task might be bad because
of a stale sleep_start value that wasn't reset at the last task switch
because the tracepoint was not active.
It also breaks the existing schedstat samples due to the side
- se->statistics.sleep_start = 0;
- se->statistics.block_start = 0;
Nor do I see means to fix it without adding overhead to the scheduler
fast path, which I'm not willing to for the sake of redundant
Most importantly, sleep time information can already be constructed
by tracing context switches and wakeups, and taking the timestamp
difference between the schedule-out, the wakeup and the schedule-in.
Signed-off-by: Peter Zijlstra <firstname.lastname@example.org>
Cc: Andrew Vagin <email@example.com>
Cc: Arnaldo Carvalho de Melo <firstname.lastname@example.org>
Cc: Frederic Weisbecker <email@example.com>
Signed-off-by: Ingo Molnar <firstname.lastname@example.org>