sysmocom
/
asterisk
11
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

res_pjsip_config_wizard: Don't crash if misconfigured 

If both send_registrations and send_auth are both set to yes,
outbound_auth/username must be set or we crash.

ASTERISK-27992 #close

Change-Id: I6418d56de1ae53f80393b314c2584048fbf7f11d
This commit is contained in:
Sean Bright 2019-02-27 20:52:26 -05:00
parent 6e8cba39a4
commit fe694de299
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
res/res_pjsip_config_wizard.c
View File

@ -910,8 +910,12 @@ static int handle_registrations(const struct ast_sorcery *sorcery, struct object
client_uri_pattern = "sip:${USERNAME}@${REMOTE_HOST}";
}
if(is_variable_true(wizvars, "sends_auth")) {
username = ast_variable_find_last_in_list(wizvars, "outbound_auth/username");
if (is_variable_true(wizvars, "sends_auth")) {
if (!(username = ast_variable_find_last_in_list(wizvars, "outbound_auth/username"))) {
ast_log(LOG_ERROR, "Wizard '%s' must have 'outbound_auth/username' if it sends"
" authentication.\n", id);
return -1;
}
} else {
username = id;
}