sysmocom
/
asterisk
11
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

bridge_simple: Suppress unchanged topology change requests 

In simple_bridge_join, we were sending topology change requests
even when the new and old topologies were the same.  In some
circumstances, this can cause unnecessary re-invites and even
a re-invite flood.  We now suppress those.

Resolves: #384
This commit is contained in:
George Joseph 2023-10-30 12:01:04 -06:00 committed by asterisk-org-access-app[bot]
parent b94f8bb216
commit ed4978ae8b
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
bridges/bridge_simple.c
View File

@ -181,7 +181,14 @@ static int simple_bridge_join(struct ast_bridge *bridge, struct ast_bridge_chann
return 0;
}
ast_channel_request_stream_topology_change(c1, new_top, &simple_bridge);
if (!ast_stream_topology_equal(new_top, existing_top)) {
ast_channel_request_stream_topology_change(c1, new_top, &simple_bridge);
} else {
ast_debug(3, "%s: Topologies already match. Current: %s Requested: %s\n",
ast_channel_name(c1),
ast_str_tmp(256, ast_stream_topology_to_str(existing_top, &STR_TMP)),
ast_str_tmp(256, ast_stream_topology_to_str(new_top, &STR_TMP)));
}
ast_stream_topology_free(new_top);
return 0;