sysmocom
/
asterisk
11
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

main/file.c: Limit media cache usage to remote files. 

When testing for the existance of a file, the media cache is searched even if
the file has no chance of being in it.  This can cause performance issues
as the media cache size increases.

As a result, calls to applications like Read and Playback using local files
must scan through the media cache before playing.  Under load and with a
large cache, this can delay the playback of those files.

This patch updates the function that checks for the existance of a file to
only consult the media cache database if the requested file is a remote path.
It introduces a new is_remote_path() function in main/file.c.

ASTERISK-28625  #close
Reported-by: kevin@phoneburner.com

Change-Id: If91137493732d9034dafa381c081c69274a7dcc9
This commit is contained in:
Kevin Reeves 2019-11-21 12:48:42 -06:00
parent 7574be5110
commit e013f502b1
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
main/file.c
View File

@ -640,6 +640,11 @@ static int is_absolute_path(const char *filename)
return filename[0] == '/';
}
static int is_remote_path(const char *filename)
{
return strstr(filename, "://") ? 1 : 0;
}
/*!
* \brief test if a file exists for a given format.
* \note result_cap is OPTIONAL
@ -653,7 +658,7 @@ static int fileexists_test(const char *filename, const char *fmt, const char *la
return 0;
}
if (!ast_media_cache_retrieve(filename, NULL, buf, buflen)) {
if (is_remote_path(filename) && !ast_media_cache_retrieve(filename, NULL, buf, buflen)) {
return filehelper(buf, result_cap, NULL, ACTION_EXISTS);
}