sysmocom
/
asterisk
11
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

res_pjsip_stir_shaken.c: Add checks for missing parameters 

* Added checks for missing session, session->channel and rdata
  in stir_shaken_incoming_request.

* Added checks for missing session, session->channel and tdata
  in stir_shaken_outgoing_request.

Resolves: #645
This commit is contained in:
George Joseph 2024-03-11 09:41:14 -06:00
parent 959babc472
commit d7597e5148
1 changed files with 20 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
res/res_pjsip_stir_shaken.c
View File

@ -211,6 +211,16 @@ static int stir_shaken_incoming_request(struct ast_sip_session *session, pjsip_r
enum process_failure_rc p_rc;
SCOPE_ENTER(1, "%s: Enter\n", session_name);
if (!session) {
SCOPE_EXIT_LOG_RTN_VALUE(1, LOG_ERROR, "No session\n");
}
if (!session->channel) {
SCOPE_EXIT_LOG_RTN_VALUE(1, LOG_ERROR, "%s: No channel\n", session_name);
}
if (!rdata) {
SCOPE_EXIT_LOG_RTN_VALUE(1, LOG_ERROR, "%s: No rdata\n", session_name);
}
/* Check if this is a reinvite. If it is, we don't need to do anything */
if (rdata->msg_info.to->tag.slen) {
SCOPE_EXIT_RTN_VALUE(0, "%s: Reinvite. No action needed\n", session_name);
@ -401,6 +411,16 @@ static void stir_shaken_outgoing_request(struct ast_sip_session *session,
const char *session_name = ast_sip_session_get_name(session);
SCOPE_ENTER(1, "%s: Enter\n", session_name);
if (!session) {
SCOPE_EXIT_LOG_RTN(LOG_ERROR, "No session\n");
}
if (!session->channel) {
SCOPE_EXIT_LOG_RTN(LOG_ERROR, "%s: No channel\n", session_name);
}
if (!tdata) {
SCOPE_EXIT_LOG_RTN(LOG_ERROR, "%s: No tdata\n", session_name);
}
old_identity = pjsip_msg_find_hdr_by_name(tdata->msg, &identity_hdr_str, NULL);
if (old_identity) {
SCOPE_EXIT_RTN("Found an existing Identity header\n");