From 2c79fd401982c7d6c5e77c09bc7035f8a3766c88 Mon Sep 17 00:00:00 2001 From: Sebastien Colleur Date: Fri, 10 Feb 2017 15:59:15 +0300 Subject: [PATCH] cmd: itest: correct calculus for long format itest shell command doesn't work correctly in long format when doing comparaison due to wrong mask value calculus that overflow on 32 bits values. Signed-off-by: Sebastien Colleur Reviewed-by: Simon Glass --- cmd/itest.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/cmd/itest.c b/cmd/itest.c index 60626c7fe9..e1896d9f97 100644 --- a/cmd/itest.c +++ b/cmd/itest.c @@ -80,7 +80,8 @@ static long evalexp(char *s, int w) l = simple_strtoul(s, NULL, 16); } - return l & ((1UL << (w * 8)) - 1); + /* avoid overflow on mask calculus */ + return (w >= sizeof(long)) ? l : (l & ((1UL << (w * 8)) - 1)); } static char * evalstr(char *s)