Automatically finding out the paths to VPN client programs does
not work when configure script is run so set the paths manually.
(From OE-Core rev: 6212703b826f4ba95196d9858a8fc033af623c7c)
Signed-off-by: Jukka Rissanen <jukka.rissanen@linux.intel.com>
Signed-off-by: Saul Wold <sgw@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
start-stop-daemon should be called with '--oknodo' instead of
'-oknodo'.
(From OE-Core rev: 40f65a76b3291ae625c072a8efebbf134b15c367)
Signed-off-by: Marc Ferland <ferlandm@sonatest.com>
Signed-off-by: Saul Wold <sgw@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Add patch file for one of the ciphers used in openssl, namely the cipher
des-ede3-cfb1. Details of the bug, without this patch, can be found here.
http://rt.openssl.org/Ticket/Display.html?id=2867
(From OE-Core rev: ed61c28b9af2f11f46488332b80752b734a3cdeb)
Signed-off-by: Muhammad Shakeel <muhammad_shakeel@mentor.com>
Signed-off-by: Saul Wold <sgw@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
This change no longer needs to be backported now that a newer version
of dhcp is being used. The patch isn't causing errors because it is not
included in the dhcp recipe's SRC_URI.
(From OE-Core rev: 4292bef50880283659dcd68198fd7948a6f48dd5)
Signed-off-by: Kevin Strasser <kevin.strasser@linux.intel.com>
Signed-off-by: Saul Wold <sgw@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Recent versions of dhcp have swapped out use of __u16 for u_int16_t and
therefor asm/types.h no longer needs to be included. Drop fixincludes.patch
from dhcp recipe.
(From OE-Core rev: 9b8f5818ada97f0803eae7687263246761e9d543)
Signed-off-by: Kevin Strasser <kevin.strasser@linux.intel.com>
Signed-off-by: Saul Wold <sgw@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Some ofono test scripts i.e. enable-modem use python-dbus module
and this must be installed along with ofono-tests package.
(From OE-Core rev: e5422ed7f3e4b1ee8554ffe3a98006477fb52c4d)
Signed-off-by: Muhammad Shakeel <muhammad_shakeel@mentor.com>
Signed-off-by: Saul Wold <sgw@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Even if we define EXTRA_CFLAGS, but it never work, since the source codes
donot refer it, and CFLAGS is given a fixed value.
(From OE-Core rev: 4a7b5963a9d18924ae0564119f4edeefaca6b415)
Signed-off-by: Roy.Li <rongqing.li@windriver.com>
Signed-off-by: Saul Wold <sgw@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Without using our python classes and having appropriate dependencies, the
build is nondeterministic, and whether a python-avahi package is produced will
vary depending on the host environment, yet avahi-discover is always produced,
and it depends on python-avahi.
(From OE-Core rev: 4599ef630c13224506671bf84569bfc240cd3032)
Signed-off-by: Christopher Larson <chris_larson@mentor.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
1. Add three ppp configuration files, make "/etc/init.d/ppp start"
be able to work with little change. provider and pap are adopted from
Ubuntu. ppp_on_boot is adopted from http://www.wlug.org.nz.
2. Use build system CFLAGS when compiling
(From OE-Core rev: 6ab8adf980f90040d3a24dd9c0f12dc04d7aadeb)
Signed-off-by: Roy.Li <rongqing.li@windriver.com>
Signed-off-by: Saul Wold <sgw@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
(From OE-Core rev: 8792b7fb4ef8d66336d52de7e81efbb818e16b08)
Signed-off-by: Jonathan Liu <net147@gmail.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
portmap splits pmap_dump and pmap_set into a different package:
portmap_utils. Since this package might not be installed, I introduce
another init file that tests for the existance of these apps before trying
to run the pmap_* commands.
(From OE-Core rev: cfa813dfc8d8d4d45d9f995d20322a3226a4e20b)
Signed-off-by: Amy Fong <amy.fong@windriver.com>
Signed-off-by: Mark Hatle <mark.hatle@windriver.com>
Signed-off-by: Saul Wold <sgw@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Make ipv6 configure dependent on DISTRO_FEATURES.
(From OE-Core rev: 984eb9e25b658c5e9a870983841060aca32bc137)
Signed-off-by: Li Wang <li.wang@windriver.com>
Signed-off-by: Mark Hatle <mark.hatle@windriver.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
- Remove /etc/resolvconf/run/interface from package as it actually uses
/etc/resolvconf/run/interface
- Create /var/run/resolvconf/interface on startup using
populate-volatiles.sh and tmpfiles.d for systemd
- Create symbolic link from /etc/resolvconf/run to /var/run/resolvconf
(From OE-Core rev: 619d78016be8d47691e3b2d218a6b855364541a3)
Signed-off-by: Jonathan Liu <net147@gmail.com>
Signed-off-by: Saul Wold <sgw@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
The /var/run directory is already created by base-files.
(From OE-Core rev: 533f34c4c4596efbd7798f0819bab9642cc97be2)
Signed-off-by: Jonathan Liu <net147@gmail.com>
Signed-off-by: Saul Wold <sgw@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Change /var/run/bind/run to /var/run/named to avoid the following error message.
chmod: cannot access '/var/run/bind/run': No such file or directory
[YOCTO #4429]
(From OE-Core rev: a32c05f691ef5620516b2f84452fb5129e16bb14)
Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
Signed-off-by: Saul Wold <sgw@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
upgrade from 1.2.7 -> 1.2.8
Removed patches that are already in the upstream.
Added a make clean routine needed because the package comes with
precompiled 64-bit objects that break the build.
(From OE-Core rev: f505e913eae5e91d494234ee38a38ac961583b12)
Signed-off-by: Andrei Dinu <andrei.adrianx.dinu@intel.com>
Signed-off-by: Saul Wold <sgw@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
The connman init script sources a setup file from /usr/lib/connman,
so we end up with no network in qemu multilib enabled images.
The init script it's installed by connman and because wired-setup
it's installed by another package (connman-conf) we can't use
libexecdir here and now (in the init script and systemd service file).
Once libexecdir changes from ${libdir}/${bpn} to something else like
/usr/libexec we could use that instead of ${libdir}/connman.
Changed in v2: - better commit message
[YOCTO #4493]
(From OE-Core rev: fca3a884e9cae13a521d840838eee3c01f0b6acf)
Signed-off-by: Stefan Stanacar <stefanx.stanacar@intel.com>
Signed-off-by: Saul Wold <sgw@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
One needs to add following statement into local.conf or distro config
PACKAGECONFIG_append_pn-connman = " openvpn vpnc l2tp pptp"
in order to activate support for these VPN technogies in ConnMan.
(From OE-Core rev: 92da847ed6cea6342bdc86de121534259332a2c3)
Signed-off-by: Jukka Rissanen <jukka.rissanen@linux.intel.com>
Signed-off-by: Saul Wold <sgw@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
This way it is easier to override settings if needed.
(From OE-Core rev: 453b96314076c2407dd56d8dc5613dc02a622e73)
Signed-off-by: Jukka Rissanen <jukka.rissanen@linux.intel.com>
Signed-off-by: Saul Wold <sgw@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Add a systemd unit file, and respect the sysvinit feature when installing the
init script.
(thanks to Jukka Rissanen for the unit file)
(From OE-Core rev: e86538db13605953465aacc3f2fb7d719dad919e)
Signed-off-by: Ross Burton <ross.burton@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
These patches where tweaking both configure.in and configure, which is
bad since configure changes after an autoconf. If the patch is re-applied
for some reason it would notice that it's already appiled and fails.
[YOCTO #4314]
(From OE-Core rev: c32b425c10566cf2aaf187e98b6e2e29022bea2f)
Signed-off-by: Saul Wold <sgw@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
- change TIST from being explicitly built, to a PACKAGECONFIG
- move wifi, 3g and bluetooth to PACKAGECONFIG
- change RDEPENDS and RPROVIDES to check PACKAGECONFIG rather
than DISTRO_FEATURES
(From OE-Core rev: da3f9f7febdc485a356ccb102e0d93cd8f059da7)
Signed-off-by: Jack Mitchell <jack.mitchell@dbbroadcast.co.uk>
Signed-off-by: Saul Wold <sgw@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
After installing Avahi we need DBus to reload it's configuration. In a
pure-systemd image there isn't a DBus init script to reload, so cut out the
middleman and just sent SIGHUP to all running dbus-daemon processes instead.
(From OE-Core rev: d6fb028de172bb649b905b605f6ddc8402af859a)
Signed-off-by: Ross Burton <ross.burton@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
After installing Avahi we need DBus to reload it's configuration. In a
pure-systemd image there isn't a DBus init script to reload, so cut out the
middleman and just sent SIGHUP to all running dbus-daemon processes instead.
(From OE-Core rev: b3e468294a0723b3ceafe2022bf9d735eee64678)
Signed-off-by: Ross Burton <ross.burton@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Other recipe versions in other layers
may be using connman.inc, so by resetting
INC_PR they go backwards in version.
Set the INC_PR correctly.
(From OE-Core rev: 2d56006cd88233c7f1f15a44f72a04bd0e441b25)
Signed-off-by: Cristian Iorga <cristian.iorga@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
bluez4 uses readline to be build, but the dependency is not listed
This is listed in the configuration log.
So we add it.
(From OE-Core rev: 99194be0332ac35da729ec53a2cc423cc520db28)
Signed-off-by: Alexandru DAMIAN <alexandru.damian@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* sysvinit/systemd assumes that update-rc.d can be inhibited
* with systemd enabled, sysvinit scripts are missing in packages
and update-rc.d needs to be put in BAD_RECOMMENDATIONS to prevent
update-rc.d trying to install them in postinst
* update-rd.c shouldn't be in DEPENDS
(From OE-Core rev: e9e4a90c7e66abe2ab2c335d60ef91e869f48693)
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Added support for correctly configuring
wired interface if systemd is the init system.
Fixes [YOCTO #4041].
(From OE-Core rev: ec5530779df23ea25729c7d19c664c05fae5758d)
Signed-off-by: Cristian Iorga <cristian.iorga@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
If run more than once, the IP addresses would be appended
to IPv4 variable. Avoid that by rewriting the IPv4 always.
(From OE-Core rev: da682e752e351e5bb7636ee187db3eabc208c177)
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
The /etc/connman is not suitable for the setup script.
There are other connman related scripts in /usr/lib/connman
so moving the wired setup script there.
(From OE-Core rev: 858ad53aee9ef5848c09d76c0e6bf464bc31d30e)
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Add patch to allow out of tree builds to work.
(From OE-Core rev: a3238c1e1317c4fd5526c8854403a2160cb51bb0)
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
neard ver 0.10:
Added initial WiFi handover support.
Added Service Name Lookup support to nfctool.
Added NDEF building unit tests.
Added State support to Bluetooth handover agent.
Added neard and neard.conf man pages.
Added a copy of the NFC kernel header.
Fixed handover validation tests failures.
Fixed Tag and Device PropertyChanged signal.
(From OE-Core rev: dff13ee38a4f6aa51722149b860a2af354d6f9e8)
Signed-off-by: Olivier Guiter <olivier.guiter@linux.intel.com>
Signed-off-by: Saul Wold <sgw@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
There is no reason to disable exec-stack only for -native builds;
binaries on the target will suffer from the same SELinux ACLs.
OpenSSL does not use executable stack so this option can be disabled
unconditionally.
(From OE-Core rev: 9c32b62d6494139daf4bab3279779c392fead116)
Signed-off-by: Enrico Scholz <enrico.scholz@sigma-chemnitz.de>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Otherwise configure will use pkg-config and may find systemd, even though we
don't want it.
(From OE-Core rev: 87fe717009fb2bcd8e5dbdf0236fe715effca89f)
Signed-off-by: Ross Burton <ross.burton@intel.com>
Signed-off-by: Saul Wold <sgw@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
The issue is that an ethernet config file is removed without
proper checks in place (rm -f), which triggers an error and
makes the connman startup script to fail.
The file is now removed with proper checks in place.
Fixes [YOCTO #4003].
(From OE-Core rev: d9349e6e28cef107ad8bd00767ceba4d8aa464dd)
Signed-off-by: Cristian Iorga <cristian.iorga@intel.com>
Signed-off-by: Saul Wold <sgw@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Copy from WORKDIR first, then modify. Improves consistency
between successive invocations of do_configure.
(From OE-Core rev: 82205345d777f7f34d43e4f81df0fa3bfe409fc4)
Signed-off-by: Andreas Oberritter <obi@opendreambox.org>
Signed-off-by: Saul Wold <sgw@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
This makes it possible to apply patches to ../src.
(From OE-Core rev: 48dbcc8c45d165e67f58a8307dde7594a28cf9bd)
Signed-off-by: Andreas Oberritter <obi@opendreambox.org>
Signed-off-by: Saul Wold <sgw@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
The Linux NFC project aims to provide a full NFC support for Linux.
It is based on the neard NFC user space stack running on top of the
Linux kernel NFC subsystem.
The code generated using this recipe was tested on a ARM11 device, with
a kernel 3.6, using, for the NFC hardware, a USB dongle with the PN533
chipset (SCL3711)
(From OE-Core rev: b2a74ae70725be7efc0226901fd560d3b3b48607)
Signed-off-by: Saul Wold <sgw@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
- connman-conf package re-implemented
- connman 1.12 introduces provisioning for
wired interfaces also;
- wired interface settings are read from
kernel cmdline if present;
- after that are passed to connman as a
config file
- for BA, this is not needed, as BA will
have a network infrastructure to work with.
Fixes [YOCTO #3227];
Fixes [YOCTO #3804];
Fixes [YOCTO #3843].
(From OE-Core rev: 5711e0cf88fac0de8a5317b16a287b335c827c8f)
Signed-off-by: Cristian Iorga <cristian.iorga@intel.com>
Signed-off-by: Saul Wold <sgw@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Backport three patches from upstream for ppc64:
http://git.kernel.org/cgit/linux/kernel/git/shemminger/iproute2.git
ae70d96 ipntable: more fixes for ppc64
a55a8fd fix dependency on sizeof(__u64) == sizeof(unsigned long long)
a7c2882 ip: fix ipv6 ntable on ppc64
(From OE-Core rev: 041f784c06403e1d418be677fd15ea159c3bf90d)
Signed-off-by: Ting Liu <b28495@freescale.com>
Signed-off-by: Saul Wold <sgw@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* The variable name was truncated.
(From OE-Core rev: 2217176a9e2b9b9ac3b1e42e0feecb2c84d60f49)
Signed-off-by: Andreas Oberritter <obi@opendreambox.org>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
We don't want the systemd inherit in avahi-ui since that causes various
warnings since PACKAGES is rewritten.
(From OE-Core rev: 02492d43cd7095acb3cf29843a50444c28b4d994)
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
The avahi recipe has a warning when build without systemd feature:
WARNING: QA Issue: avahi: Files/directories were installed but not shipped
/usr/share/dbus-1
The /usr/share/dbus-1 is empty without systemd feature, there would be
/usr/share/dbus-1/system-services with systemd. Use rmdir to fix the
problem, and remove the ${datadir}/dbus-1/interfaces from the FILES list
which had been removed clearly by the do_install.
[YOCTO #3939]
(From OE-Core rev: 51cfcef15b59f7b97c871d9c0d6bf560c7b06c9b)
Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
There are various usages of ALLOW_EMPTY with no packages specified. This
is not recommended syntax, nor is it likely to be supported in the future.
This patch improves the references in OE-Core, either removing them if they're
pointless (e.g. when PACKAGES="") or specifying which package it applies to.
(From OE-Core rev: fe81bd4f600877e63433184cfc2e22c33bb77db6)
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Latest version bump started failing for ppc32
attached patch is a backport from 3.9-rc1
(From OE-Core rev: 08be60d903ee97859295387b3418d5db85ab16e1)
Signed-off-by: Khem Raj <raj.khem@gmail.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
When the /var/lib/nfs/v4recovery directory is not present, NFSD cannot
record the upcall state and cannot end the 90-second grace period on
startup. This is true even when NFS4 is not being served according to
nfsstat.
More details and discussion here:
https://lkml.org/lkml/2012/6/11/206
(From OE-Core rev: c7cb5cb92770615ffd302f737d0fef3f2300c321)
Signed-off-by: Rich Dubielzig <rich.dubielzig@windriver.com>
Signed-off-by: Saul Wold <sgw@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
This should compile against the userspace safe kernel headers
(From OE-Core rev: e443887379fae4b4fd70d1cd6f7d0d7f064a2cb1)
Signed-off-by: Saul Wold <sgw@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Needed because the 3.8 if_bridge.h uses in6_addr before it's defined
(From OE-Core rev: 5c4979b93855a57334fac61455b7563e4a43f8ab)
Signed-off-by: Saul Wold <sgw@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Changed LIC_FILES_CHKSUM due to whitespace and GNU address difference
(From OE-Core rev: e2294db8e31aacdc27204e0b0fe5ff9221ee768a)
Signed-off-by: Saul Wold <sgw@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
connmanctl is available in a new
package: connman-client
(From OE-Core rev: d926de687ba45fed993af7feba8574b76293b939)
Signed-off-by: Cristian Iorga <cristian.iorga@intel.com>
Signed-off-by: Saul Wold <sgw@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
(From OE-Core rev: 352b3e3663fc4ccab2d8240176f4b085db726e82)
Signed-off-by: Radu Moisan <radu.moisan@intel.com>
Signed-off-by: Sander van Grieken <sander@outrightsolutions.nl>
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
Signed-off-by: Ross Burton <ross.burton@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
packaging these extra directories is needed
Otherwise rpcbind wont start as it
expects /var/lib/nfs/statd to exist.
This fixes the issue where automounter fails
to mount since rpcbind did not start correctly
Failed to open directory sm: No such file or directory
(From OE-Core rev: edd7b7f9f1cea921bdc9480c2a120f6abc6b0c9c)
Signed-off-by: Khem Raj <raj.khem@gmail.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
do_configure was using relative paths in do_configure with the assumption that
$S is the same as $B. This isn't always true, so explicitly use $S.
(From OE-Core rev: a01c103f54d2f588d78756d19f879eb82d0e5ae4)
Signed-off-by: Ross Burton <ross.burton@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
do_configure was assuming that $B is $S, so the relative path was wrong. Add a
missing $S.
(From OE-Core rev: 9c947cf76235624f3661341154575688cf528bed)
Signed-off-by: Ross Burton <ross.burton@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
When 'bitbake -c configure connman-gnome' is executed from scratch, it fails
with syntax error parsing `IT_PROG_INTLTOOL(0.35.0)' in configure.in. This
is caused by its definition is not included into aclocal.m4
Adding intltool-native to DEPENDS is gonna fix it.
[YOCTO #3815]
[ CQID: WIND00401118 ]
(From OE-Core rev: 283dd547b5ed657f871b9330ff4d8d5b3afd1e32)
Signed-off-by: Ming Liu <ming.liu@windriver.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Jukka Rissanen
Marc Ferland
Roy.Li
Muhammad Shakeel
Kevin Strasser
Saul Wold
Christopher Larson
Andrei Dinu
Cristian Iorga
Jack Mitchell
Jonathan Liu
Amy Fong
Li Wang
Chen Qi
Stefan Stanacar
Ross Burton
Paul Eggleton
Phil Blundell
Emilia Ciobanu
Richard Purdie
Ting Liu
Radu Moisan
Alexandru DAMIAN
Martin Jansa
Olivier Guiter
Enrico Scholz
Andreas Oberritter
Robert Yang
Khem Raj
Rich Dubielzig
Randy MacLeod
Ming Liu