sysmo-bts
/
generic-poky
9
0
Fork 0
Code Pull Requests Releases Activity

Hob: avoid the image selection dialog to walk through all directories and its sub-directories, when users click "My images". 

The current implementation of the image selection dialog walks through all directories and its sub-directories, when users click "My images" to choose a directory. If the directory is /, the system becomes slow. This patch is to avoid walking through all directories but the child directories only, given a directory.

(Bitbake rev: 536fa633b442ff37d43f45cf346ba281d69de496)

Signed-off-by: Shane Wang <shane.wang@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
This commit is contained in:
Shane Wang 2012-02-29 22:14:59 +08:00 committed by Richard Purdie
parent 030ba4bc71
commit b8582dc996
1 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
bitbake/lib/bb/ui/crumbs/hig.py
View File

@ -582,6 +582,7 @@ class ImageSelectionDialog (gtk.Dialog):
self.image_folder = image_folder
self.image_types = image_types
self.image_list = []
self.image_names = []
# create visual elements on the dialog
@ -645,13 +646,17 @@ class ImageSelectionDialog (gtk.Dialog):
dialog.destroy()
def fill_image_store(self):
self.image_list = []
self.image_store.clear()
imageset = set()
for root, dirs, files in os.walk(self.image_folder):
# ignore the sub directories
dirs[:] = []
for f in files:
for image_type in self.image_types:
if f.endswith('.' + image_type):
imageset.add(f.rsplit('.' + image_type)[0])
self.image_list.append(f)
for image in imageset:
self.image_store.set(self.image_store.append(), 0, image, 1, False)
@ -665,9 +670,8 @@ class ImageSelectionDialog (gtk.Dialog):
while iter:
path = self.image_store.get_path(iter)
if self.image_store[path][1]:
for root, dirs, files in os.walk(self.image_folder):
for f in files:
if f.startswith(self.image_store[path][0] + '.'):
self.image_names.append(f)
for f in self.image_list:
if f.startswith(self.image_store[path][0] + '.'):
self.image_names.append(f)
break
iter = self.image_store.iter_next(iter)