From 71c1de347eef07a2059fc4544dc3cae090181f44 Mon Sep 17 00:00:00 2001 From: Joshua Lock Date: Wed, 28 Mar 2012 12:15:02 -0700 Subject: [PATCH] lib/bb/ui/crumbs/hig: fix layers_changed test Because we sort the treeview to list specific layers at the top, and therefore implicitly change the sorting of the underlying model, we can't be certain that the original layer list will equal the new layer list despite the included layers being the same. To ensure we can do a simple equality test to determine whether the layers have been modified first sort the lists to ensure we're comparing based on contents alone. (Bitbake rev: ae86cd8b4ef1e43b79230326ccba69e2900d074f) Signed-off-by: Joshua Lock Signed-off-by: Richard Purdie --- bitbake/lib/bb/ui/crumbs/hig.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/bitbake/lib/bb/ui/crumbs/hig.py b/bitbake/lib/bb/ui/crumbs/hig.py index 9927370f91..c47751c0fa 100644 --- a/bitbake/lib/bb/ui/crumbs/hig.py +++ b/bitbake/lib/bb/ui/crumbs/hig.py @@ -952,7 +952,10 @@ class LayerSelectionDialog (CrumbsDialog): layers.append(model.get_value(it, 0)) it = model.iter_next(it) - self.layers_changed = (self.layers != layers) + orig_layers = sorted(self.layers) + layers.sort() + + self.layers_changed = (orig_layers != layers) self.layers = layers """