From 48cd942be181f23e3b7d7cff1753013ed36c9486 Mon Sep 17 00:00:00 2001 From: Scott Garman Date: Sun, 19 Jun 2011 16:15:25 -0700 Subject: [PATCH] fetch2/git.py: improve error reporting when an invalid protocol is used When an invalid 'protocol' parameter is used in a git SRC_URI, the error reported was not helpful: ERROR: Function 'Fetcher failure for URL: 'None'. fatal: Could not make temporary directory: No such file or directory So instead check that ud.proto is set to something valid, and if not raise a meaningful ParameterError which explains that the protocol type is the source of the problem. This fixes bug [YOCTO #1142] (Bitbake rev: a2a29b72275ab03a263f4479a590b92111a0d6a8) Signed-off-by: Scott Garman Signed-off-by: Richard Purdie --- bitbake/lib/bb/fetch2/git.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/bitbake/lib/bb/fetch2/git.py b/bitbake/lib/bb/fetch2/git.py index 6979beaef5..f3bc793a6a 100644 --- a/bitbake/lib/bb/fetch2/git.py +++ b/bitbake/lib/bb/fetch2/git.py @@ -88,6 +88,9 @@ class Git(FetchMethod): else: ud.proto = "git" + if not ud.proto in ('git', 'file', 'ssh', 'http', 'https'): + raise bb.fetch2.ParameterError("Invalid protocol type", ud.url) + ud.nocheckout = ud.parm.get("nocheckout","0") == "1" ud.rebaseable = ud.parm.get("rebaseable","0") == "1"