sysmo-bts
/
generic-poky
9
0
Fork 0
Code Pull Requests Releases Activity

populate-extfs.sh: error out if debugfs encounters some error 

Previously, even if we encounter some error when populating the
ext filesystem, we don't error out and the rootfs process still
succeeds.

However, what's really expected is that the populate-extfs.sh script
should error out if something wrong happens when using `debugfs' to
generate the ext filesystem. For example, if there's not enough block
in the filesystem, and allocating a block for some file fails, the
failure should not be ignored. Otherwise, we will have a successful
build but a corrupted filesystem.

The debugfs returns 0 as long as the command is valid. That is, even
if the command fails, the debugfs still returns 0. That's really a
pain here. That's why this patch checks the error output to see whether
there's any error logged.

(From OE-Core rev: 468d3e60ee10348578f78f846e87c02359fdb8bf)

Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
This commit is contained in:
Chen Qi 2014-06-19 10:11:33 +08:00 committed by Richard Purdie
parent 8c346a66b5
commit 3ceb90eacd
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.8/populate-extfs.sh
View File

@ -94,4 +94,9 @@ DEBUGFS="debugfs"
echo "sif $SRC links_count $LN_CNT"
done
rm -fr $INODE_DIR
} | $DEBUGFS -w -f - $DEVICE
} | $DEBUGFS -w -f - $DEVICE 2>&1 1>/dev/null | grep '.*: .*'
if [ $? = 0 ]; then
echo "Some error occured while executing [$DEBUGFS -w -f - $DEVICE]"
exit 1
fi