bitbake: data: Use direct iteration, not keys()
Profiling shows the creation of keys() has overhead and we're better using an iterator rather than the memory associated with the huge list of keys when iterating the whoe datastore. We minimise the number of times we do this to twice only per recipe. (Bitbake rev: e63448d9ee331b0f45fb9a0197d0dbee49eb2fa0) Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
This commit is contained in:
parent
f78db82e1a
commit
36b4fcde7a
|
@ -148,7 +148,7 @@ def expandKeys(alterdata, readdata = None):
|
|||
readdata = alterdata
|
||||
|
||||
todolist = {}
|
||||
for key in keys(alterdata):
|
||||
for key in alterdata:
|
||||
if not '${' in key:
|
||||
continue
|
||||
|
||||
|
@ -341,7 +341,7 @@ def build_dependencies(key, keys, shelldeps, vardepvals, d):
|
|||
|
||||
def generate_dependencies(d):
|
||||
|
||||
keys = set(key for key in d.keys() if not key.startswith("__"))
|
||||
keys = set(key for key in d if not key.startswith("__"))
|
||||
shelldeps = set(key for key in keys if d.getVarFlag(key, "export") and not d.getVarFlag(key, "unexport"))
|
||||
vardepvals = set(key for key in keys if d.getVarFlag(key, "vardepvalue"))
|
||||
|
||||
|
|
Loading…
Reference in New Issue