sysmo-bts
/
generic-poky
9
0
Fork 0
Code Pull Requests Releases Activity

replace os.system with subprocess.call 

Replace os.system with subprocess.call since the older function would
fail (more or less) silently if the executed program cannot be found

More info:
http://docs.python.org/library/subprocess.html#subprocess-replacements

[YOCTO #2075]

(Bitbake rev: f5b3bf115dc1ffbfb241a49cec0fc3654cb71021)

Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
This commit is contained in:
Robert Yang 2012-05-20 20:36:05 +08:00 committed by Richard Purdie
parent 358016f463
commit 10a0f9ed92
3 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
bitbake/lib/bb/fetch2/perforce.py
View File

@ -27,6 +27,7 @@ BitBake build tools.
from future_builtins import zip
import os
import subprocess
import logging
import bb
from bb import data
@ -184,7 +185,7 @@ class Perforce(FetchMethod):
dest = list[0][len(path)+1:]
where = dest.find("#")
os.system("%s%s print -o %s/%s %s" % (p4cmd, p4opt, module, dest[:where], list[0]))
subprocess.call("%s%s print -o %s/%s %s" % (p4cmd, p4opt, module, dest[:where], list[0]), shell=True)
count = count + 1
if count == 0:

3
bitbake/lib/bb/ui/crumbs/imagedetailspage.py
View File

@ -25,6 +25,7 @@ import gtk
from bb.ui.crumbs.hobcolor import HobColors
from bb.ui.crumbs.hobwidget import hic, HobViewTable, HobAltButton, HobButton
from bb.ui.crumbs.hobpages import HobPage
import subprocess
#
# ImageDetailsPage
@ -297,7 +298,7 @@ class ImageDetailsPage (HobPage):
self.show_all()
def view_files_clicked_cb(self, button, image_addr):
os.system("xdg-open /%s" % image_addr)
subprocess.call("xdg-open /%s" % image_addr, shell=True)
def refresh_package_detail_box(self, image_size):
self.package_detail.update_line_widgets("Total image size: ", image_size)

4
bitbake/lib/bb/ui/ncurses.py
View File

@ -47,7 +47,7 @@
from __future__ import division
import logging
import os, sys, curses, itertools, time
import os, sys, curses, itertools, time, subprocess
import bb
import xmlrpclib
from bb import ui
@ -286,7 +286,7 @@ class NCursesUI:
# bb.error("log data follows (%s)" % logfile)
# number_of_lines = data.getVar("BBINCLUDELOGS_LINES", d)
# if number_of_lines:
# os.system('tail -n%s %s' % (number_of_lines, logfile))
# subprocess.call('tail -n%s %s' % (number_of_lines, logfile), shell=True)
# else:
# f = open(logfile, "r")
# while True: