sysmo-bts
/
generic-poky
9
0
Fork 0
Code Pull Requests Releases Activity

rpm: remove bashisms: [ x == x ] -> [ x = x ] 

The postinst and postrm of rpm contained a bashism, that could in some
situations potentially cause ldconfig not be triggered when it should
be. If you use dash on host, test would fail because of syntax errors.
But on host, it should fail because of the comparison. On target, you
often use busybox ash, and it supports == as an alias for =. So in
practice, only if you use a shell like dash on target, you'll run into
issues with this.

(From OE-Core rev: 4fd33ca846ba9f61e72a176a6462443c9fb5ddc2)

Signed-off-by: Olof Johansson <olofjn@axis.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
This commit is contained in:
Olof Johansson 2016-01-19 14:45:32 +01:00 committed by Richard Purdie
parent 2dbd61f242
commit 0916235adf
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
meta/recipes-devtools/rpm/rpm_4.11.2.bb
View File

@ -101,8 +101,7 @@ do_install_append() {
}
pkg_postinst_${PN}() {
[ "x\$D" == "x" ] && ldconfig
[ "x\$D" = "x" ] && ldconfig
test -f ${localstatedir}/lib/rpm/Packages || rpm --initdb
rm -f ${localstatedir}/lib/rpm/Filemd5s \
${localstatedir}/lib/rpm/Filedigests \
@ -112,7 +111,7 @@ pkg_postinst_${PN}() {
}
pkg_postrm_${PN}() {
[ "x\$D" == "x" ] && ldconfig
[ "x\$D" = "x" ] && ldconfig
}