memtest: cleanup requests of regions
This patch removes the first and last entry check inside the loop. There should be no functional changes there. Signed-off-by: Alexander Aring <alex.aring@gmail.com> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
This commit is contained in:
parent
9880cd69f4
commit
276a3741b9
|
@ -74,34 +74,25 @@ static int request_memtest_regions(struct list_head *list)
|
||||||
continue;
|
continue;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
r = list_first_entry(&bank->res->children,
|
||||||
|
struct resource, sibling);
|
||||||
|
start = PAGE_ALIGN(bank->res->start);
|
||||||
|
end = PAGE_ALIGN_DOWN(r->start);
|
||||||
|
r_prev = r;
|
||||||
|
if (start != end) {
|
||||||
|
size = end - start;
|
||||||
|
ret = alloc_memtest_region(list, start, size);
|
||||||
|
if (ret < 0)
|
||||||
|
return ret;
|
||||||
|
}
|
||||||
/*
|
/*
|
||||||
* We assume that the regions are sorted in this list
|
* We assume that the regions are sorted in this list
|
||||||
* So the first element has start boundary on bank->res->start
|
* So the first element has start boundary on bank->res->start
|
||||||
* and the last element hast end boundary on bank->res->end
|
* and the last element hast end boundary on bank->res->end.
|
||||||
|
*
|
||||||
|
* Between used regions. Start from second entry.
|
||||||
*/
|
*/
|
||||||
list_for_each_entry(r, &bank->res->children, sibling) {
|
list_for_each_entry_from(r, &bank->res->children, sibling) {
|
||||||
/*
|
|
||||||
* Do on head element for bank boundary
|
|
||||||
*/
|
|
||||||
if (r->sibling.prev == &bank->res->children) {
|
|
||||||
/*
|
|
||||||
* remember last used element
|
|
||||||
*/
|
|
||||||
start = PAGE_ALIGN(bank->res->start);
|
|
||||||
end = PAGE_ALIGN_DOWN(r->start);
|
|
||||||
r_prev = r;
|
|
||||||
if (start == end)
|
|
||||||
continue;
|
|
||||||
size = end - start;
|
|
||||||
|
|
||||||
ret = alloc_memtest_region(list, start, size);
|
|
||||||
if (ret < 0)
|
|
||||||
return ret;
|
|
||||||
continue;
|
|
||||||
}
|
|
||||||
/*
|
|
||||||
* Between used regions
|
|
||||||
*/
|
|
||||||
start = PAGE_ALIGN(r_prev->end);
|
start = PAGE_ALIGN(r_prev->end);
|
||||||
end = PAGE_ALIGN_DOWN(r->start);
|
end = PAGE_ALIGN_DOWN(r->start);
|
||||||
r_prev = r;
|
r_prev = r;
|
||||||
|
@ -112,21 +103,20 @@ static int request_memtest_regions(struct list_head *list)
|
||||||
ret = alloc_memtest_region(list, start, size);
|
ret = alloc_memtest_region(list, start, size);
|
||||||
if (ret < 0)
|
if (ret < 0)
|
||||||
return ret;
|
return ret;
|
||||||
|
}
|
||||||
|
|
||||||
if (list_is_last(&r->sibling, &bank->res->children)) {
|
/*
|
||||||
/*
|
* Do on head element for bank boundary.
|
||||||
* Do on head element for bank boundary
|
*/
|
||||||
*/
|
r = list_last_entry(&bank->res->children,
|
||||||
start = PAGE_ALIGN(r->end);
|
struct resource, sibling);
|
||||||
end = PAGE_ALIGN_DOWN(bank->res->end) - 1;
|
start = PAGE_ALIGN(r->end);
|
||||||
size = end - start + 1;
|
end = PAGE_ALIGN_DOWN(bank->res->end) - 1;
|
||||||
if (start >= end)
|
size = end - start + 1;
|
||||||
continue;
|
if (start < end) {
|
||||||
|
ret = alloc_memtest_region(list, start, size);
|
||||||
ret = alloc_memtest_region(list, start, size);
|
if (ret < 0)
|
||||||
if (ret < 0)
|
return ret;
|
||||||
return ret;
|
|
||||||
}
|
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
Loading…
Reference in New Issue