spreecommerce
/
spree_paypal_express
1
0
Fork 0
Code Pull Requests Releases Activity

Add amount_in_cents method to prevent 'magic number' calculations everywhere

This commit is contained in:
Ryan Bigg 2011-12-17 10:01:28 +11:00
parent 6e6b553313
commit 526cf0a492
1 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
app/models/spree/paypal_account.rb
View File

@ -8,7 +8,7 @@ class Spree::PaypalAccount < ActiveRecord::Base
def capture(payment)
authorization = find_authorization(payment)
ppx_response = payment.payment_method.provider.capture((100 * payment.amount).to_i, authorization.params["transaction_id"], :currency => payment.payment_method.preferred_currency)
ppx_response = payment.payment_method.provider.capture(amount_in_cents(payment.amount), authorization.params["transaction_id"], :currency => payment.payment_method.preferred_currency)
if ppx_response.success?
record_log payment, ppx_response
payment.complete
@ -27,7 +27,7 @@ class Spree::PaypalAccount < ActiveRecord::Base
amount = payment.credit_allowed >= payment.order.outstanding_balance.abs ? payment.order.outstanding_balance : payment.credit_allowed
ppx_response = payment.payment_method.provider.credit(amount.nil? ? (100 * amount).to_i : (100 * amount).to_i, authorization.params['transaction_id'])
ppx_response = payment.payment_method.provider.credit(amount.nil? ? amount_in_cents(amount) : amount_in_cents(amount), authorization.params['transaction_id'])
if ppx_response.success?
record_log payment, ppx_response
@ -95,4 +95,10 @@ class Spree::PaypalAccount < ActiveRecord::Base
logger.error(msg)
raise Spree::GatewayError.new(msg)
end
private
def amount_in_cents(amount)
(100 * amount).to_i
end
end