From 0427146bf4ba3e885b0051f6757e0da8fecf9b22 Mon Sep 17 00:00:00 2001 From: paulcc Date: Wed, 15 Jul 2009 08:14:18 +0100 Subject: [PATCH] only add insurance_offered tag when it's present in options, and fix the details tag name --- .../billing/gateways/paypal/paypal_common_api.rb | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/lib/active_merchant/billing/gateways/paypal/paypal_common_api.rb b/lib/active_merchant/billing/gateways/paypal/paypal_common_api.rb index 0bab237..61eb202 100644 --- a/lib/active_merchant/billing/gateways/paypal/paypal_common_api.rb +++ b/lib/active_merchant/billing/gateways/paypal/paypal_common_api.rb @@ -291,7 +291,7 @@ module ActiveMerchant #:nodoc: def add_payment_detail_item(xml, item) currency_code = options[:currency] || currency(item[:amount]) - xml.tag! 'n2:PaymentDetailItem' do + xml.tag! 'n2:PaymentDetailsItem' do xml.tag! 'n2:Name', item[:name] unless item[:name].blank? xml.tag! 'n2:Description', item[:description] unless item[:description].blank? xml.tag! 'n2:Number', item[:sku] unless item[:sku].blank? @@ -323,11 +323,10 @@ module ActiveMerchant #:nodoc: end # don't enforce inclusion yet - see how it works - xml.tag! 'n2:InsuranceOptionOffered', options[:insurance_offered] ? '1' : '0' + xml.tag! 'n2:InsuranceOptionOffered', options[:insurance_offered] ? '1' : '0' unless options[:insurance_offered].blank? xml.tag! 'n2:InsuranceTotal', amount(options[:insurance]), 'currencyID' => currency_code unless options[:insurance].blank? xml.tag! 'n2:ShippingDiscount', amount(options[:ship_discount]), 'currencyID' => currency_code unless options[:ship_discount].blank? - # query - use slices too? or just risk reject? (QQ: injection risk???) xml.tag! 'n2:OrderDescription', options[:description] unless options[:description].blank? xml.tag! 'n2:Custom', options[:custom] unless options[:custom].blank?