From 3001d7a8de0f9385386b78819105efca895feb6e Mon Sep 17 00:00:00 2001 From: Harald Welte Date: Mon, 15 Feb 2021 20:13:19 +0100 Subject: [PATCH] fix inquiry (no pickings, and hence no packaging_tare) --- models/shipcloud_delivery_carrier.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/models/shipcloud_delivery_carrier.py b/models/shipcloud_delivery_carrier.py index 4f5a83d..03068e5 100644 --- a/models/shipcloud_delivery_carrier.py +++ b/models/shipcloud_delivery_carrier.py @@ -87,13 +87,14 @@ class SCDeliveryCarrier(models.Model): """Convert an Odoo stock.picking or sale.order into a shipcloud package""" pkg = {} pkg['type'] = 'parcel' - pkg['weight'] = self._get_weight_with_tare(order, picking) if picking: + pkg['weight'] = self._get_weight_with_tare(order, picking) pkg['length'] = picking.packaging_length pkg['width'] = picking.packaging_width pkg['height'] = picking.packaging_height else: # we assume an average mass density of 0.5kg per dm3 (litre) + pkg['weight'] = self._get_weight(order, picking) est = self.estimate_dimensions(pkg['weight'], 0.5) pkg['length'] = est[0] pkg['width'] = est[1]