Commit Graph

74880 Commits

Author SHA1 Message Date
Xavier Morel 184f396ea0 [FIX] web_diagram: can't mark empty strings for translations, gettext does not like empty msgids 2014-12-02 09:40:59 +01:00
Anthony Muschang 0088bd578b [FIX] account_analytic_plans: take analytic distribution into account when creating a move line from bank statement reconciliation 2014-12-02 09:24:56 +01:00
Jeremy Kersten 5d58b5551f [FIX] website_forum: use other attr than value to init select2
The backend would otherwise fail because the value has been already processed
2014-12-01 20:03:31 +01:00
Jeremy Kersten ad1ca233ca [FIX] website_forum: fix error 500 when editing an answer
Was caused by missing tags.
Also fix also backwards-compatibility for textext selection method.
2014-12-01 20:02:06 +01:00
Jeremy Kersten 3c0cf7c977 [FIX] website_forum: restore bind to onclick because CKE Editor uses it, so on('click', fun) breaks things.
Fixes bugs with z-index error on some popups (image selector for example...)
2014-12-01 20:01:00 +01:00
Olivier Dony 0ddee644d6 [FIX] website_forum: allow moderators to see misbehaving user profiles
This is to help forum moderators to fight against
spammers. It was previously difficult as the spammer
profile became unreachable as soon as their karma
went below 1, even if they had other questions
or answers still published.
2014-12-01 19:30:57 +01:00
Denis Ledoux 6f21306dba [FIX] website: responsive images in table for Firefox only
It looks there is a bug in Firefox concerning responsive images in table. See bugzilla https://bugzilla.mozilla.org/show_bug.cgi?id=975632
Bootstrap advises to use width: 100% for .img-responsive as workaround were needed.
The @moz-document is to apply this for Mozilla only.

opw-617582
opw-618659
2014-12-01 18:28:18 +01:00
Antoine Huvelle d7a47d0d1f [FIX] analytic_user_function: inherit conflict on account type
The field account_id was inherited with position="replace" meaning we erased
future changes made into hr_timesheet_sheet (41f2eba missed "type in []" and
65f31b9 missed use_timesheets).
Replace by position="attributes" to only change what matters: the on_change.
Fixes #3974
2014-12-01 17:43:59 +01:00
Martin Trigaux b3060f2771 [FIX] website: can not change website name
The website name is by default "localhost" (used in the page title in the format
"Current Page | Website Name") but there were no way to change it.
Fixes #3493
2014-12-01 16:50:51 +01:00
Frédéric Van der Essen 02bdbee088 Merge pull request #3009 from initOS/8.0-fix_escpos_with_non_rgba_image
Bug: Exception when printing POS receipt via hardware proxy
2014-12-01 15:55:17 +01:00
Frédéric van der Essen d700c78c56 [FIX] point_of_sale: correctly handle various xmlrpc errors that appear in offline mode 2014-12-01 15:46:29 +01:00
Christophe Simonis d37dd37059 [MERGE] forward port of branch saas-3 up to e1e7dc0 2014-12-01 15:42:51 +01:00
Christophe Simonis e1e7dc0af9 [MERGE] forward port of branch 7.0 up to 419d934 2014-12-01 15:33:48 +01:00
Denis Ledoux 64fd5288c8 [FIX] account: There is no sale_refund nor purchase_refund analytic journal
During rev. cbe2dbb, type2journal was refactored, and set as a global variable in the top of the file, as it was use everywhere accross the file.
But, in this specific method _get_journal_analytic, this type2journal dict wasn't the same as everywhere else, as you can see at rev. d2ff95f for example. We must therefore set a specific type2journal dict for this specific method.
2014-12-01 15:31:12 +01:00
Eddy Ernesto del Valle Pino 419d934143 [FIX] base_calendar: meetings email notification recipients
Reminder emails are generated based on the list of attendees.
The email_to field used to be a string with a list of emails separated by spaces
while the comma is the valid separator (RFC2822).
Fixes #3933 #3784 #2033
2014-12-01 14:53:13 +01:00
Ravi Gohil 1fe6e8172d [IMP] website_mail: mailing editor buttons
Button "Save and continue" was wrongly named as it worked only once the template
is not in edit mode (so already saved).
Hide the button to only get it in readonly mode and rename it for better
understanding of its purpose. (opw 614563)
2014-12-01 11:45:43 +01:00
Jacques-Etienne Baudoux aba75e7578 [FIX] base: oe_subtotal_footer_separator width
Make sure a too long value in the subtotal will not overlap the form sheet
Fixes #3698
2014-12-01 10:42:36 +01:00
Géry Debongnie 29f895f947 [FIX] fix editing one2many in some cases (web)
See issue #3964 for more detail.  Main problem was caused by commit
f0e331e005.  It set the key name+'__display' to false when reloading
a record for all field types, but it was only concerned with many2many.
2014-12-01 10:29:00 +01:00
Loïc Bellier cdce2e2283 [FIX] stock: Never hide the invoice control on pickings
Invoice control field was invisible, and we cannot change value if none selected or copy picking in.
Fixes #3636
2014-11-28 17:55:48 +01:00
sve-openerp b747b3d30b [IMP] product: usability improvement in pricelist
Explicitly specifiy that quantities are in product uom
2014-11-28 15:50:57 +01:00
Christophe Simonis ec30b21336 [MERGE] forward port of branch 7.0 up to de07c64 2014-11-28 15:16:38 +01:00
Amit Vora 4bf9dc4078 [IMP] [FIX] website_blog: better follow mechanism. Now people following
a blog will receive notifications only for published posts. They
will not receive all comments of all posts anymore.
When commenting a post users will receive the answers.

Added tests to try to test this behavior.
2014-11-28 15:12:14 +01:00
Géry Debongnie 3078cfbbd1 [FIX] remove filter for new leads/opportunity (crm)
requested by fp. the filter is wrong and not very useful from a
functional viewpoint.
2014-11-28 14:26:25 +01:00
Denis Ledoux 45551cf78c [FIX] web: use mutex to wait for onchanges
This fix is related to c12a2e1d16

Mutex allow to wait sequentially for mutex
Besides, if one of the onchanges deferreds fails, it does not resolve the mutex until all deferreds of the mutex are resolved.

Besides, we now wait for the onchanges mutex between each field commited value (line 596) in case the commited value leaded to a new onchanges, that we should wait for before commiting the rest of the values.
2014-11-28 13:39:47 +01:00
Akash Balar d4027e6182 [IMP] account: account.statement.operation.template model
- better many2one ondelete strategies
- domain set on fields, not views
- added domain on analytic_account_id field
2014-11-28 08:42:01 +01:00
Arthur Maniet d7a46b4d84 [FIX] account: floating point comparisons in get_reconciliation_proposition 2014-11-28 05:20:09 +01:00
Christophe Simonis 5f47fc84e9 [FIX] web: m2o search facet do no set `default_*` context key for "name_search" values 2014-11-27 17:06:48 +01:00
Olivier Dony fc85a7ee5c [FIX] product: remove unnecessary UoM rounding step, add missing test
Remove the intermediate rounding inside _compute_qty(), as it
is not necessary after rev. fa2f7b86 and has undesired side-effects.

An extra float_round() operation inside _compute_qty()
had been added at rev. 311c77bb to avoid a float representation
error in UoM factors that could bias the ceiling() operation
done as the last conversion step.

Example 1:
Dozen has a factor of 1/12, which was previously stored in the
database with a decimal accuracy of 12 significant decimal digits.
This meant the factor was exactly stored as 0.08333333333333.
When reading this back into a Python float, the precision was not
sufficient, and the UoM conversion of 1 Dozen to Units gave a
result of 12.00000000000047961...
After the final ceiling() operation to Unit's rounding, the
converted value ended up as 13.

This problem was initially solved using an extra rounding.

However at revision fa2f7b86 the decimal precision used to store
UoM factors was increased to preserve all significant digits.
This added the extra precision necessary to read the Dozen factor
back into an accurate float value of 1/12, and the conversion of
1 Dozen now gives 12.0 Units, even without the intermediate
rounding operation. (Works for other factor values too)

At the same time that extra rounding operation has undesired
side-effects, as it requires a fixed precision derived from
the rounding precisions of the UoMs. But there is no given precision
that would work in all cases for this intermediate value. It is
always possible to find a valid combination of UoM roundings
that breaks that intermediate step, e.g. by forcing integer
roundings.

Example 2:
Let Grams have a rounding precision set to 1 because no smaller
quantities are allowed, and Kilograms a rounding of 0.001 to allow
representing 1 Gram. (gram factor = 1000 and kilogram rounding = .001
by default)
If we try to convert 1234 Grams into Kilograms, the extra rounding
introduced in 311c77bb will cause a rounding of 1234.0/1000.0 at
the precision of Grams (1), which gives 1.0 as a result.
The net result of this conversion gives 1234.0 Gram = 1.0 Kilogram,
while the correct result (1.234 Kilogram) is perfectly compatible
with the UoM settings.

Similar errors could be triggered with various rounding settings, as
long as the intermediate rounding needs a finite precision.

Two extra tests have been added to cover Example 1 and Example 2.

--
Related to #2072, #1125, #1126, #2672
Closes #2495, #2498
2014-11-27 16:44:34 +01:00
Denis Ledoux 15d87a1732 [FIX] web_graph: pass context to fields_get for translation
In graph views, fields from the pivot table were not translated in the user language
We pass the context, containing the user language, to fields_get in order to get the translation
This is also done by the search view, in search.js line 1978 at this rev.

opw-616713
2014-11-27 16:06:05 +01:00
Denis Ledoux 62bc63e44f [FIX] web: force company_logo change on company change
In multi company environment, the company logo was not updated on company change in the user preferences
This disrupted the end user, as he might think the company change did not happen.
2014-11-27 15:21:25 +01:00
Denis Ledoux e347011f24 [MERGE] forward port of branch 7.0 up to 2080ea0 2014-11-27 13:27:37 +01:00
Denis Ledoux 2080ea0f0a [FIX] stock: on stock picking invoicing, allow to pick a journal if no move line 2014-11-27 13:26:57 +01:00
Mohammad Alhashash 2461baa0dd [FIX] stock: prevent serial number deletion on stock.move
prodlot_id field may be required due to constraint `_check_tracking`.
When a stock.production.lot is deleted, the constraint on linked stock.move is
not checked. To avoid inconsistency, restrict the suppression.
To allow the modification of existing stock.move, remove the states attribute on
the field definition.

As removal of serial may impact the traceability, it makes sense on buisness
point of view to force the modification of previous stock.move, even if the
constraint would not have been violated.
The list of linked stock.move is present on the serial form view making
the operation easier.

Fixes #3560, lp:1176912
2014-11-27 12:47:41 +01:00
Denis Ledoux 117d0d0ca2 [FIX] sale_margin: stored field functions cannot trigger other stored field functions
the update of sale.order margin field was trigger with the margin stored field of sale.order.line: This cannot work with the old api
2014-11-27 12:06:19 +01:00
Will Stott c854404a2c [FIX] purchase(_requisition): typo negociation -> negotiation 2014-11-27 10:36:55 +01:00
Olivier Dony 9bc712b075 [REV] product: rev. 42f5114 needs further review
Incorrect use of stock.move in product module + needs review.

This reverts commit 42f511405a4efe88e3903a4b4040ec9d83e462e2:
"[IMP] When no stock moves, change whatever you want, otherwise no change at all for UoM.  #3440 Enhancement request richard-willowit"
2014-11-26 18:20:28 +01:00
Josse Colpaert 42f511405a [IMP] When no stock moves, change whatever you want, otherwise no change at all for UoM. #3440 Enhancement request richard-willowit
The default UoM can only be changed when there are no stock moves (or only cancelled ones), but to any category.
The purchase UoM can be changed whenever you want, but has to be in the same category as the default UoM.

Closes #3440

[IMP] When no stock moves, change whatever you want, otherwise no change at all for UoM.  #3440 Enhancement request richard-willowit

[FIX] Remove line

[FIX] Constraint should be applied when UoM or PO UoM is changed
2014-11-26 18:01:00 +01:00
Jeremy Kersten 0313218123 [FIX] website_forum: Forum, use old API in v8. forum was not a browse record, so we need to re-browse. Tags: Force to delete tag. Before old tag deleted was not removed from relation, Now we use a 6 to force the update, followed by 0 to create. 2014-11-26 17:44:52 +01:00
Denis Ledoux 2b0a8363d9 [FIX] sale_layout: set 0 as default value for categ_sequence
Otherwise, in some cases, the categ_sequence can be set to null, which is not ordered the same way than 0, and you won't be able to sort lines with null and 0 as categ_sequence between each others
2014-11-26 17:03:42 +01:00
Maria G fde2046d5e [FIX] hr_attendance: use float division for worked_hours field
Used to be rounded to integer while the field is a float.
Fixes #3526
2014-11-26 16:46:26 +01:00
Frédéric Van der Essen 94aded554c Merge pull request #3803 from TheCloneMaster/patch-7
POS is loading all partners, not only customers
2014-11-26 16:38:44 +01:00
Pierre Verkest f0e331e005 [FIX] correctly update many2many in listview (web client)
Fixes the issue #1216 (follow the link for more information). The issue
was caused by a hack in list view: the magical suffix __display is used
in render_cell to determine if a many2many field should be updated. This
commit simply makes sure that old many2many fields + __display keys are
cleared.

A better way would be to redesign/refactor the list view to avoid that
hack in the first place.  But this would be a much more complex task.
2014-11-26 15:42:34 +01:00
Mario Arias Badila d349723271 [point_of_sale] Domain functions to literals
Replaced domain functions with literals where there are only constants
2014-11-26 08:32:33 -06:00
Edy Kendengis 002664ed79 [IMP] stock: display company in location tree view 2014-11-26 15:32:25 +01:00
Christophe Matthieu d3c562d4e8 [FIX] product: keep attribute on a variant with only one attribute
When adding informational attribute, with only one possible value, it used to be skipped.
Instead keep it and add it on every variant.

To avoid dropping and recreating product (and lose eventual customisations), the attributes with only one possible value are set on every product.
This makes sure that in following test, these are not considered in variants_inactive variable.

Fixes #3204
2014-11-26 14:35:08 +01:00
Denis Ledoux 02f4f9a572 [MERGE] forward port of branch 7.0 up to e2dd18f 2014-11-26 12:35:36 +01:00
Denis Ledoux e2dd18f1e7 [FIX] mrp: prevent recursion from phantom boms with no lines
if the bom is phantom and has no line, we attempt to find a new bom with the default product uom
This is possible that we find the same bom that the current one
In such a case, we must not explode, to avoid recursion.
2014-11-26 12:34:45 +01:00
Tymoteusz Motylewski 856eba1de0 [IMP] website_sale: performance on category page
public_categ_ids field was moved to product.template object
2014-11-26 12:09:37 +01:00
Martin Trigaux 342ec1083e [FIX] sale_service: typo in string Thick -> Tick 2014-11-26 12:07:53 +01:00
Arthur Maniet a6de1b150c [IMP] account: bank statement reconciliation widget: allow to filter move lines on due date 2014-11-26 11:38:32 +01:00