From fc11b58239f4097be907be3ad41b1c0757b00e7a Mon Sep 17 00:00:00 2001 From: Alexis de Lattre Date: Fri, 12 Dec 2014 12:21:35 +0100 Subject: [PATCH] [FIX] stock: service lines duplication when grouping DO invoices This is possible that changes happen during the loop in the multiple pickings: an update in a picking could update another picking. The browse must therefore be done inside the loop to update the pickings with the latest changes. Fixes #4201 --- addons/stock/stock.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/addons/stock/stock.py b/addons/stock/stock.py index 276e24b4e2d..7fa2f4e92a2 100644 --- a/addons/stock/stock.py +++ b/addons/stock/stock.py @@ -1132,7 +1132,9 @@ class stock_picking(osv.osv): invoices_group = {} res = {} inv_type = type - for picking in self.browse(cr, uid, ids, context=context): + for picking_id in ids: + # The browse inside the loop is done on purpose, as a change in the pickings during the loop is possible + picking = self.browse(cr, uid, picking_id, context=context) if picking.invoice_state != '2binvoiced': continue partner = self._get_partner_to_invoice(cr, uid, picking, context=context)