[FIX] sale_order_dates: remove return from for loop and cleaning

bzr revid: mra@mra-laptop-20101022131615-35i9ss38tud6bylp
This commit is contained in:
Mustufa Rangwala 2010-10-22 18:46:15 +05:30
parent 58f7dceab9
commit f7eae25635
2 changed files with 8 additions and 8 deletions

View File

@ -26,9 +26,8 @@ from osv import fields, osv
class sale_order_dates(osv.osv):
_inherit = 'sale.order'
_name = 'sale.order'
def _get_effective_date(self, cr, uid, ids, name, arg, context={}):
def _get_effective_date(self, cr, uid, ids, name, arg, context=None):
res = {}
dates_list = []
for order in self.browse(cr, uid, ids):
@ -39,9 +38,9 @@ class sale_order_dates(osv.osv):
res[order.id] = min(dates_list)
else:
res[order.id] = False
return res
return res
def _get_commitment_date(self, cr, uid, ids, name, arg, context={}):
def _get_commitment_date(self, cr, uid, ids, name, arg, context=None):
res = {}
dates_list = []
for order in self.browse(cr, uid, ids):
@ -52,12 +51,12 @@ class sale_order_dates(osv.osv):
dates_list.append(dt_s)
if dates_list:
res[order.id] = min(dates_list)
return res
return res
_columns = {
'commitment_date': fields.function(_get_commitment_date, method=True,store=True, type='date', string='Commitment Date', help="Date on which delivery of products is to be made"),
'commitment_date': fields.function(_get_commitment_date, method=True, store=True, type='date', string='Commitment Date', help="Date on which delivery of products is to be made"),
'requested_date': fields.date('Requested Date', help="Date on which customer has requested for sales"),
'effective_date': fields.function(_get_effective_date, method=True, type='date', store=True,string='Effective Date',help="Date on which picking is created"),
'effective_date': fields.function(_get_effective_date, method=True, type='date', store=True, string='Effective Date',help="Date on which picking is created"),
}
sale_order_dates()

View File

@ -17,5 +17,6 @@
</field>
</field>
</record>
</data>
</openerp>
</openerp>