From dd714ace55bd70a855e660ff67823144163b6dce Mon Sep 17 00:00:00 2001 From: Nicolas Lempereur Date: Wed, 4 May 2016 13:14:25 +0200 Subject: [PATCH] [IMP] web: multi-click on save on view form (no fp) When clicking on save several time when editing a view form it can be saved several times which can be an issue for one to many. The normal happenstance when saving should be as follow: -> save (click) -> wait write result -> received write result -> reload the form with updated data and updates buttons But when clicking several time, it could become: -> save (click) -> wait write result -> received write result -> save (click) -> wait write result -> received write result -> reload the form with updated data and updates buttons This commit only reinstate the saving feature once the form is reloaded. closes #11926 opw-671793 note: no need to forward-port --- addons/web/static/src/js/view_form.js | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/addons/web/static/src/js/view_form.js b/addons/web/static/src/js/view_form.js index 72744618fa4..cdf73ee06ae 100644 --- a/addons/web/static/src/js/view_form.js +++ b/addons/web/static/src/js/view_form.js @@ -726,14 +726,16 @@ instance.web.FormView = instance.web.View.extend(instance.web.form.FieldManagerM $(e.target).attr("disabled", true); return this.save().done(function(result) { self.trigger("save", result); - self.reload().then(function() { + self.reload().always(function(){ + $(e.target).attr("disabled", false); + }).then(function() { self.to_view_mode(); var menu = instance.webclient.menu; if (menu) { menu.do_reload_needaction(); } }); - }).always(function(){ + }).fail(function(){ $(e.target).attr("disabled", false); }); },