From 9d4bea10eb6adff7a960a1833307a171fee46a90 Mon Sep 17 00:00:00 2001 From: buke Date: Mon, 9 Feb 2015 12:55:54 +0800 Subject: [PATCH] [IMP] hr_attendance: performance improvement has_group is cached and do not fetch all the users with a slow `group.users` --- addons/hr_attendance/hr_attendance.py | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/addons/hr_attendance/hr_attendance.py b/addons/hr_attendance/hr_attendance.py index 6b0960feaaf..4718aee96a4 100644 --- a/addons/hr_attendance/hr_attendance.py +++ b/addons/hr_attendance/hr_attendance.py @@ -149,10 +149,7 @@ class hr_employee(osv.osv): def _attendance_access(self, cr, uid, ids, name, args, context=None): # this function field use to hide attendance button to singin/singout from menu - group = self.pool.get('ir.model.data').get_object(cr, uid, 'base', 'group_hr_attendance') - visible = False - if uid in [user.id for user in group.users]: - visible = True + visible = self.pool.get("res.users").has_group(cr, uid, "base.group_hr_attendance") return dict([(x, visible) for x in ids]) _columns = {