odoo
/
odoo
2
0
Fork 0
Code Pull Requests Releases Activity

[8.0][FIX] Make on_change in address_format divs work 

To reproduce the bug:

- Create a partner.
- Set it state "Alaska".
- Country becomes "United States".
- Set a country for YourCompany, such as Spain.
- Create a partner.
- Set it state "Alaska".
- Country remains blank.

Also, `node.xpath("//field")` was running over every `<field>` in the
view, not just those inside the `<div class="address_format">`. Now it
only traverses the right nodes, which renders every affected view
faster.
This commit is contained in:
Jairo Llopis 2016-01-25 18:41:28 +01:00 committed by Goffin Simon
parent b955bac100
commit 906bf16a76
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
openerp/addons/base/res/res_partner.py
View File

@ -67,10 +67,12 @@ class format_address(object):
doc = etree.fromstring(arch)
for node in doc.xpath("//div[@class='address_format']"):
tree = etree.fromstring(v % {'city': _('City'), 'zip': _('ZIP'), 'state': _('State')})
for child in node.xpath("//field"):
if child.attrib.get('modifiers'):
for field in tree.xpath("//field[@name='%s']" % child.attrib.get('name')):
for child in node.xpath(".//field"):
for field in tree.xpath("//field[@name='%s']" % child.attrib.get("name")):
if child.attrib.get("modifiers"):
field.attrib['modifiers'] = child.attrib.get('modifiers')
if child.attrib.get("on_change"):
field.attrib["on_change"] = child.attrib.get("on_change")
node.getparent().replace(node, tree)
arch = etree.tostring(doc)
break