From 5a26c2d3ec1321721772936b2d96d6ecfd98cddd Mon Sep 17 00:00:00 2001
From: Jeremy Kersten <jke@odoo.com>
Date: Thu, 5 Feb 2015 12:48:48 +0100
Subject: [PATCH] [FIX] crm,hr,base: disable the quick create for country field

The creation of a country is not something to create at flight !
The impact could be bigger that what people was expected (no accounting configured, ...).

The bad manipulation is more often the responsible, eg 'Belgium ' was creating a new country with a trailing whitespace, while the user didn't see the difference and use both country withtout making the diff.
---
 addons/crm/crm_lead_view.xml                 | 4 ++--
 addons/hr/hr_view.xml                        | 2 +-
 openerp/addons/base/res/res_bank_view.xml    | 2 +-
 openerp/addons/base/res/res_partner_view.xml | 4 ++--
 4 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/addons/crm/crm_lead_view.xml b/addons/crm/crm_lead_view.xml
index e294d768054..95e020bc35d 100644
--- a/addons/crm/crm_lead_view.xml
+++ b/addons/crm/crm_lead_view.xml
@@ -128,7 +128,7 @@
                                     <field name="state_id" on_change="onchange_state(state_id)" options='{"no_open": True}' placeholder="State" style="width: 24%%"/>
                                     <field name="zip" placeholder="ZIP" style="width: 34%%"/>
                                 </div>
-                                <field name="country_id" placeholder="Country" options='{"no_open": True}'/>
+                                <field name="country_id" placeholder="Country" options='{"no_open": True, "no_create": True}'/>
                             </div>
                         </group>
                         <group>
@@ -457,7 +457,7 @@
                                             <field name="state_id" options='{"no_open": True}' on_change="onchange_state(state_id)" placeholder="State" style="width: 24%%"/>
                                             <field name="zip" placeholder="ZIP" style="width: 34%%"/>
                                         </div>
-                                        <field name="country_id" placeholder="Country" options='{"no_open": True}'/>
+                                        <field name="country_id" placeholder="Country" options='{"no_open": True, "no_create": True}'/>
                                     </div>
                                 </group>
 
diff --git a/addons/hr/hr_view.xml b/addons/hr/hr_view.xml
index a045baadfb7..12a3889c6d2 100644
--- a/addons/hr/hr_view.xml
+++ b/addons/hr/hr_view.xml
@@ -63,7 +63,7 @@
                             <page string="Personal Information" groups="base.group_hr_user">
                                 <group>
                                     <group string="Citizenship &amp; Other Info">
-                                        <field name="country_id" options='{"no_open": True}'/>
+                                        <field name="country_id" options='{"no_open": True, "no_create": True}'/>
                                         <field name="identification_id" groups="base.group_hr_user"/>
                                         <field name="passport_id" groups="base.group_hr_user"/>
                                         <field name="bank_account_id"/>
diff --git a/openerp/addons/base/res/res_bank_view.xml b/openerp/addons/base/res/res_bank_view.xml
index 5cb5d2d5e7d..ef1c1452427 100644
--- a/openerp/addons/base/res/res_bank_view.xml
+++ b/openerp/addons/base/res/res_bank_view.xml
@@ -114,7 +114,7 @@
                                     <field name="city" class="oe_inline" placeholder="City"/>
                                 </div>
                                 <field name="state_id" placeholder="State" options='{"no_open": True}'/>
-                                <field name="country_id" placeholder="Country" options='{"no_open": True}'/>
+                                <field name="country_id" placeholder="Country" options='{"no_open": True, "no_create": True}'/>
                             </div>
                         </group>
                         <group name="bank" string="Information About the Bank">
diff --git a/openerp/addons/base/res/res_partner_view.xml b/openerp/addons/base/res/res_partner_view.xml
index 34ad354a99d..06230b17651 100644
--- a/openerp/addons/base/res/res_partner_view.xml
+++ b/openerp/addons/base/res/res_partner_view.xml
@@ -170,7 +170,7 @@
                                     <field name="state_id" class="oe_no_button" placeholder="State" style="width: 37%%" options='{"no_open": True}' on_change="onchange_state(state_id)" attrs="{'readonly': [('use_parent_address','=',True)]}"/>
                                     <field name="zip" placeholder="ZIP" style="width: 20%%" attrs="{'readonly': [('use_parent_address','=',True)]}"/>
                                 </div>
-                                <field name="country_id" placeholder="Country" class="oe_no_button" options='{"no_open": True}' attrs="{'readonly': [('use_parent_address','=',True)]}"/>
+                                <field name="country_id" placeholder="Country" class="oe_no_button" options='{"no_open": True, "no_create": True}' attrs="{'readonly': [('use_parent_address','=',True)]}"/>
                             </div>
                             <field name="website" widget="url" placeholder="e.g. www.odoo.com"/>
                         </group>
@@ -284,7 +284,7 @@
                                                     <field name="state_id" class="oe_no_button" placeholder="State" style="width: 37%%" options='{"no_open": True}' on_change="onchange_state(state_id)"/>
                                                     <field name="zip" placeholder="ZIP" style="width: 20%%"/>
                                                 </div>
-                                                <field name="country_id" placeholder="Country" class="oe_no_button" options='{"no_open": True}'/>
+                                                <field name="country_id" placeholder="Country" class="oe_no_button" options='{"no_open": True, "no_create": True}'/>
                                             </div>
                                         </group>
                                         <field name="supplier" invisible="True"/>