From 879ba64ed79e6e3d4c46348bceebd9eed4e1862f Mon Sep 17 00:00:00 2001 From: Harald Welte Date: Tue, 1 Jun 2021 23:25:52 +0200 Subject: [PATCH] Raise exception if customs_code is not set During WPINT label generation I'm trying to remove all spaces from the customs code (HTS) by using the str.replace() method. However, if no customs code is set at all, we run into an exception as the "False" instance of the bool type doesn't have a replace() method. Closes: SYS#5451 --- models/dp_delivery_carrier.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/models/dp_delivery_carrier.py b/models/dp_delivery_carrier.py index 82e02ec..e55d54a 100644 --- a/models/dp_delivery_carrier.py +++ b/models/dp_delivery_carrier.py @@ -152,6 +152,8 @@ class DPDeliveryCarrier(models.Model): else: raise Warning('Product %s has no Country of Origin defined' % (ptempl.name)) weight = ptempl.weight + if not ptempl.customs_code: + raise Warning('Product %s has no Customs Code defined' % (templ.name)) hts = ptmpl.customs_code.replace(' ', '') desc = ptmpl.customs_description_en if line.procurement_id and line.procurement_id.sale_line_id: