123 lines
4.2 KiB
Diff
123 lines
4.2 KiB
Diff
From d68c697225a753c6cbfbd8ac77a77b6d0f47d688 Mon Sep 17 00:00:00 2001
|
|
Message-Id: <d68c697225a753c6cbfbd8ac77a77b6d0f47d688.1596234184.git.zanussi@kernel.org>
|
|
In-Reply-To: <378ee68279f6a7631221f2670a9298620148690d.1596234183.git.zanussi@kernel.org>
|
|
References: <378ee68279f6a7631221f2670a9298620148690d.1596234183.git.zanussi@kernel.org>
|
|
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
|
|
Date: Fri, 15 Jan 2016 16:33:34 +0100
|
|
Subject: [PATCH 233/329] net/core: protect users of napi_alloc_cache against
|
|
reentrance
|
|
Origin: https://www.kernel.org/pub/linux/kernel/projects/rt/4.19/older/patches-4.19.135-rt60.tar.xz
|
|
|
|
On -RT the code running in BH can not be moved to another CPU so CPU
|
|
local variable remain local. However the code can be preempted
|
|
and another task may enter BH accessing the same CPU using the same
|
|
napi_alloc_cache variable.
|
|
This patch ensures that each user of napi_alloc_cache uses a local lock.
|
|
|
|
Cc: stable-rt@vger.kernel.org
|
|
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
|
|
---
|
|
net/core/skbuff.c | 25 +++++++++++++++++++------
|
|
1 file changed, 19 insertions(+), 6 deletions(-)
|
|
|
|
diff --git a/net/core/skbuff.c b/net/core/skbuff.c
|
|
index 6ca7cb2b4364..c5c0d2095873 100644
|
|
--- a/net/core/skbuff.c
|
|
+++ b/net/core/skbuff.c
|
|
@@ -332,6 +332,7 @@ struct napi_alloc_cache {
|
|
static DEFINE_PER_CPU(struct page_frag_cache, netdev_alloc_cache);
|
|
static DEFINE_PER_CPU(struct napi_alloc_cache, napi_alloc_cache);
|
|
static DEFINE_LOCAL_IRQ_LOCK(netdev_alloc_lock);
|
|
+static DEFINE_LOCAL_IRQ_LOCK(napi_alloc_cache_lock);
|
|
|
|
static void *__netdev_alloc_frag(unsigned int fragsz, gfp_t gfp_mask)
|
|
{
|
|
@@ -363,9 +364,13 @@ EXPORT_SYMBOL(netdev_alloc_frag);
|
|
|
|
static void *__napi_alloc_frag(unsigned int fragsz, gfp_t gfp_mask)
|
|
{
|
|
- struct napi_alloc_cache *nc = this_cpu_ptr(&napi_alloc_cache);
|
|
+ struct napi_alloc_cache *nc;
|
|
+ void *data;
|
|
|
|
- return page_frag_alloc(&nc->page, fragsz, gfp_mask);
|
|
+ nc = &get_locked_var(napi_alloc_cache_lock, napi_alloc_cache);
|
|
+ data = page_frag_alloc(&nc->page, fragsz, gfp_mask);
|
|
+ put_locked_var(napi_alloc_cache_lock, napi_alloc_cache);
|
|
+ return data;
|
|
}
|
|
|
|
void *napi_alloc_frag(unsigned int fragsz)
|
|
@@ -461,9 +466,10 @@ EXPORT_SYMBOL(__netdev_alloc_skb);
|
|
struct sk_buff *__napi_alloc_skb(struct napi_struct *napi, unsigned int len,
|
|
gfp_t gfp_mask)
|
|
{
|
|
- struct napi_alloc_cache *nc = this_cpu_ptr(&napi_alloc_cache);
|
|
+ struct napi_alloc_cache *nc;
|
|
struct sk_buff *skb;
|
|
void *data;
|
|
+ bool pfmemalloc;
|
|
|
|
len += NET_SKB_PAD + NET_IP_ALIGN;
|
|
|
|
@@ -481,7 +487,10 @@ struct sk_buff *__napi_alloc_skb(struct napi_struct *napi, unsigned int len,
|
|
if (sk_memalloc_socks())
|
|
gfp_mask |= __GFP_MEMALLOC;
|
|
|
|
+ nc = &get_locked_var(napi_alloc_cache_lock, napi_alloc_cache);
|
|
data = page_frag_alloc(&nc->page, len, gfp_mask);
|
|
+ pfmemalloc = nc->page.pfmemalloc;
|
|
+ put_locked_var(napi_alloc_cache_lock, napi_alloc_cache);
|
|
if (unlikely(!data))
|
|
return NULL;
|
|
|
|
@@ -492,7 +501,7 @@ struct sk_buff *__napi_alloc_skb(struct napi_struct *napi, unsigned int len,
|
|
}
|
|
|
|
/* use OR instead of assignment to avoid clearing of bits in mask */
|
|
- if (nc->page.pfmemalloc)
|
|
+ if (pfmemalloc)
|
|
skb->pfmemalloc = 1;
|
|
skb->head_frag = 1;
|
|
|
|
@@ -724,23 +733,26 @@ void __consume_stateless_skb(struct sk_buff *skb)
|
|
|
|
void __kfree_skb_flush(void)
|
|
{
|
|
- struct napi_alloc_cache *nc = this_cpu_ptr(&napi_alloc_cache);
|
|
+ struct napi_alloc_cache *nc;
|
|
|
|
+ nc = &get_locked_var(napi_alloc_cache_lock, napi_alloc_cache);
|
|
/* flush skb_cache if containing objects */
|
|
if (nc->skb_count) {
|
|
kmem_cache_free_bulk(skbuff_head_cache, nc->skb_count,
|
|
nc->skb_cache);
|
|
nc->skb_count = 0;
|
|
}
|
|
+ put_locked_var(napi_alloc_cache_lock, napi_alloc_cache);
|
|
}
|
|
|
|
static inline void _kfree_skb_defer(struct sk_buff *skb)
|
|
{
|
|
- struct napi_alloc_cache *nc = this_cpu_ptr(&napi_alloc_cache);
|
|
+ struct napi_alloc_cache *nc;
|
|
|
|
/* drop skb->head and call any destructors for packet */
|
|
skb_release_all(skb);
|
|
|
|
+ nc = &get_locked_var(napi_alloc_cache_lock, napi_alloc_cache);
|
|
/* record skb to CPU local list */
|
|
nc->skb_cache[nc->skb_count++] = skb;
|
|
|
|
@@ -755,6 +767,7 @@ static inline void _kfree_skb_defer(struct sk_buff *skb)
|
|
nc->skb_cache);
|
|
nc->skb_count = 0;
|
|
}
|
|
+ put_locked_var(napi_alloc_cache_lock, napi_alloc_cache);
|
|
}
|
|
void __kfree_skb_defer(struct sk_buff *skb)
|
|
{
|
|
--
|
|
2.17.1
|
|
|