69 lines
2.3 KiB
Diff
69 lines
2.3 KiB
Diff
From 2368c6033f87efcb5b6a0ce41578038b648ec2c0 Mon Sep 17 00:00:00 2001
|
|
Message-Id: <2368c6033f87efcb5b6a0ce41578038b648ec2c0.1596234184.git.zanussi@kernel.org>
|
|
In-Reply-To: <378ee68279f6a7631221f2670a9298620148690d.1596234183.git.zanussi@kernel.org>
|
|
References: <378ee68279f6a7631221f2670a9298620148690d.1596234183.git.zanussi@kernel.org>
|
|
From: Thomas Gleixner <tglx@linutronix.de>
|
|
Date: Wed, 26 Sep 2012 16:21:08 +0200
|
|
Subject: [PATCH 232/329] net: Another local_irq_disable/kmalloc headache
|
|
Origin: https://www.kernel.org/pub/linux/kernel/projects/rt/4.19/older/patches-4.19.135-rt60.tar.xz
|
|
|
|
Replace it by a local lock. Though that's pretty inefficient :(
|
|
|
|
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
|
|
---
|
|
net/core/skbuff.c | 10 ++++++----
|
|
1 file changed, 6 insertions(+), 4 deletions(-)
|
|
|
|
diff --git a/net/core/skbuff.c b/net/core/skbuff.c
|
|
index 0629ca89ab74..6ca7cb2b4364 100644
|
|
--- a/net/core/skbuff.c
|
|
+++ b/net/core/skbuff.c
|
|
@@ -63,6 +63,7 @@
|
|
#include <linux/errqueue.h>
|
|
#include <linux/prefetch.h>
|
|
#include <linux/if_vlan.h>
|
|
+#include <linux/locallock.h>
|
|
|
|
#include <net/protocol.h>
|
|
#include <net/dst.h>
|
|
@@ -330,6 +331,7 @@ struct napi_alloc_cache {
|
|
|
|
static DEFINE_PER_CPU(struct page_frag_cache, netdev_alloc_cache);
|
|
static DEFINE_PER_CPU(struct napi_alloc_cache, napi_alloc_cache);
|
|
+static DEFINE_LOCAL_IRQ_LOCK(netdev_alloc_lock);
|
|
|
|
static void *__netdev_alloc_frag(unsigned int fragsz, gfp_t gfp_mask)
|
|
{
|
|
@@ -337,10 +339,10 @@ static void *__netdev_alloc_frag(unsigned int fragsz, gfp_t gfp_mask)
|
|
unsigned long flags;
|
|
void *data;
|
|
|
|
- local_irq_save(flags);
|
|
+ local_lock_irqsave(netdev_alloc_lock, flags);
|
|
nc = this_cpu_ptr(&netdev_alloc_cache);
|
|
data = page_frag_alloc(nc, fragsz, gfp_mask);
|
|
- local_irq_restore(flags);
|
|
+ local_unlock_irqrestore(netdev_alloc_lock, flags);
|
|
return data;
|
|
}
|
|
|
|
@@ -412,13 +414,13 @@ struct sk_buff *__netdev_alloc_skb(struct net_device *dev, unsigned int len,
|
|
if (sk_memalloc_socks())
|
|
gfp_mask |= __GFP_MEMALLOC;
|
|
|
|
- local_irq_save(flags);
|
|
+ local_lock_irqsave(netdev_alloc_lock, flags);
|
|
|
|
nc = this_cpu_ptr(&netdev_alloc_cache);
|
|
data = page_frag_alloc(nc, len, gfp_mask);
|
|
pfmemalloc = nc->pfmemalloc;
|
|
|
|
- local_irq_restore(flags);
|
|
+ local_unlock_irqrestore(netdev_alloc_lock, flags);
|
|
|
|
if (unlikely(!data))
|
|
return NULL;
|
|
--
|
|
2.17.1
|
|
|