105 lines
3.0 KiB
Diff
105 lines
3.0 KiB
Diff
From: Ben Hutchings <ben@decadent.org.uk>
|
|
Subject: radeon: Firmware is required for DRM and KMS on R600 onward
|
|
Date: Tue, 08 Jan 2013 03:25:52 +0000
|
|
Bug-Debian: https://bugs.debian.org/607194
|
|
Bug-Debian: https://bugs.debian.org/607471
|
|
Bug-Debian: https://bugs.debian.org/610851
|
|
Bug-Debian: https://bugs.debian.org/627497
|
|
Bug-Debian: https://bugs.debian.org/632212
|
|
Bug-Debian: https://bugs.debian.org/637943
|
|
Bug-Debian: https://bugs.debian.org/649448
|
|
Bug-Debian: https://bugs.debian.org/697229
|
|
Forwarded: no
|
|
|
|
radeon requires firmware/microcode for the GPU in all chips, but for
|
|
newer chips (apparently R600 'Evergreen' onward) it also expects
|
|
firmware for the memory controller and other sub-blocks.
|
|
|
|
radeon attempts to gracefully fall back and disable some features if
|
|
the firmware is not available, but becomes unstable - the framebuffer
|
|
and/or system memory may be corrupted, or the display may stay black.
|
|
This does not seem to happen if KMS is disabled, but with both KMS
|
|
and GPU acceleration disabled radeon is not doing anything useful!
|
|
|
|
Therefore, perform a basic check for the existence of
|
|
/lib/firmware/radeon when a device is probed, and abort if it is
|
|
missing, except for the pre-R600 KMS case.
|
|
|
|
---
|
|
--- a/drivers/gpu/drm/radeon/radeon_drv.c
|
|
+++ b/drivers/gpu/drm/radeon/radeon_drv.c
|
|
@@ -41,6 +41,9 @@
|
|
#include <drm/drm_gem.h>
|
|
|
|
#include "drm_crtc_helper.h"
|
|
+#include <linux/namei.h>
|
|
+#include <linux/path.h>
|
|
+
|
|
/*
|
|
* KMS wrapper.
|
|
* - 2.0.0 - initial interface
|
|
@@ -362,6 +365,42 @@ static struct drm_driver driver_old = {
|
|
|
|
static struct drm_driver kms_driver;
|
|
|
|
+/* Test that /lib/firmware/radeon is a directory (or symlink to a
|
|
+ * directory). We could try to match the udev search path, but let's
|
|
+ * assume people take the easy route and install
|
|
+ * firmware-linux-nonfree.
|
|
+ */
|
|
+static bool radeon_firmware_installed(void)
|
|
+{
|
|
+#if IS_BUILTIN(CONFIG_DRM_RADEON)
|
|
+ /* It may be too early to tell. Assume it's there. */
|
|
+ return true;
|
|
+#else
|
|
+ struct path path;
|
|
+
|
|
+ if (kern_path("/lib/firmware/radeon", LOOKUP_DIRECTORY | LOOKUP_FOLLOW,
|
|
+ &path) == 0) {
|
|
+ path_put(&path);
|
|
+ return true;
|
|
+ }
|
|
+
|
|
+ return false;
|
|
+#endif
|
|
+}
|
|
+
|
|
+#ifdef CONFIG_DRM_RADEON_UMS
|
|
+static int
|
|
+radeon_ums_pci_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
|
|
+{
|
|
+ if (!radeon_firmware_installed()) {
|
|
+ DRM_ERROR("radeon DRM requires firmware-linux-nonfree.\n");
|
|
+ return -ENODEV;
|
|
+ }
|
|
+
|
|
+ return 0;
|
|
+}
|
|
+#endif
|
|
+
|
|
static int radeon_kick_out_firmware_fb(struct pci_dev *pdev)
|
|
{
|
|
struct apertures_struct *ap;
|
|
@@ -388,6 +427,12 @@ static int radeon_pci_probe(struct pci_d
|
|
{
|
|
int ret;
|
|
|
|
+ if ((ent->driver_data & RADEON_FAMILY_MASK) >= CHIP_R600 &&
|
|
+ !radeon_firmware_installed()) {
|
|
+ DRM_ERROR("radeon kernel modesetting for R600 or later requires firmware-linux-nonfree.\n");
|
|
+ return -ENODEV;
|
|
+ }
|
|
+
|
|
/* Get rid of things like offb */
|
|
ret = radeon_kick_out_firmware_fb(pdev);
|
|
if (ret)
|
|
@@ -610,6 +655,7 @@ static struct pci_driver *pdriver;
|
|
static struct pci_driver radeon_pci_driver = {
|
|
.name = DRIVER_NAME,
|
|
.id_table = pciidlist,
|
|
+ .probe = radeon_ums_pci_probe,
|
|
};
|
|
#endif
|
|
|