34 lines
1.2 KiB
Diff
34 lines
1.2 KiB
Diff
From: Oliver Neukum <oneukum@suse.com>
|
|
Date: Tue, 27 Oct 2015 09:51:34 -0200
|
|
Subject: [media] usbvision fix overflow of interfaces array
|
|
Origin: http://git.linuxtv.org/cgit.cgi/media_tree.git/commit?id=588afcc1c0e45358159090d95bf7b246fb67565f
|
|
|
|
This fixes the crash reported in:
|
|
http://seclists.org/bugtraq/2015/Oct/35
|
|
The interface number needs a sanity check.
|
|
|
|
Signed-off-by: Oliver Neukum <oneukum@suse.com>
|
|
Cc: Vladis Dronov <vdronov@redhat.com>
|
|
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
|
|
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
|
|
---
|
|
drivers/media/usb/usbvision/usbvision-video.c | 7 +++++++
|
|
1 file changed, 7 insertions(+)
|
|
|
|
--- a/drivers/media/usb/usbvision/usbvision-video.c
|
|
+++ b/drivers/media/usb/usbvision/usbvision-video.c
|
|
@@ -1533,6 +1533,13 @@ static int usbvision_probe(struct usb_in
|
|
printk(KERN_INFO "%s: %s found\n", __func__,
|
|
usbvision_device_data[model].model_string);
|
|
|
|
+ /*
|
|
+ * this is a security check.
|
|
+ * an exploit using an incorrect bInterfaceNumber is known
|
|
+ */
|
|
+ if (ifnum >= USB_MAXINTERFACES || !dev->actconfig->interface[ifnum])
|
|
+ return -ENODEV;
|
|
+
|
|
if (usbvision_device_data[model].interface >= 0)
|
|
interface = &dev->actconfig->interface[usbvision_device_data[model].interface]->altsetting[0];
|
|
else
|