37 lines
1.3 KiB
Diff
37 lines
1.3 KiB
Diff
From: Steven Rostedt <rostedt@goodmis.org>
|
|
Date: Wed, 16 May 2018 09:36:46 -0400
|
|
Subject: [PATCH 4/5] tracing: Uninitialized variable in
|
|
create_tracing_map_fields()
|
|
|
|
From: Dan Carpenter <dan.carpenter@oracle.com>
|
|
|
|
[ commit b28d7b2dc27f0eef1ae608b49d6860f2463910f1 ]
|
|
|
|
Smatch complains that idx can be used uninitialized when we check if
|
|
(idx < 0). It has to be the first iteration through the loop and the
|
|
HIST_FIELD_FL_STACKTRACE bit has to be clear and the HIST_FIELD_FL_VAR
|
|
bit has to be set to reach the bug.
|
|
|
|
Link: http://lkml.kernel.org/r/20180328114815.GC29050@mwanda
|
|
|
|
Fixes: 30350d65ac56 ("tracing: Add variable support to hist triggers")
|
|
Acked-by: Tom Zanussi <tom.zanussi@linux.intel.com>
|
|
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
|
|
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
|
|
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
|
|
---
|
|
kernel/trace/trace_events_hist.c | 2 +-
|
|
1 file changed, 1 insertion(+), 1 deletion(-)
|
|
|
|
--- a/kernel/trace/trace_events_hist.c
|
|
+++ b/kernel/trace/trace_events_hist.c
|
|
@@ -4412,7 +4412,7 @@ static int create_tracing_map_fields(str
|
|
struct tracing_map *map = hist_data->map;
|
|
struct ftrace_event_field *field;
|
|
struct hist_field *hist_field;
|
|
- int i, idx;
|
|
+ int i, idx = 0;
|
|
|
|
for_each_hist_field(i, hist_data) {
|
|
hist_field = hist_data->fields[i];
|