52 lines
2.3 KiB
Diff
52 lines
2.3 KiB
Diff
From: David Howells <dhowells@redhat.com>
|
|
Date: Tue, 4 Apr 2017 16:54:21 +0100
|
|
Subject: [04/62] Annotate hardware config module parameters in
|
|
drivers/char/mwave/
|
|
Origin: https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/commit?id=70f233e85b60cb259279e451313dce6cbc84d041
|
|
|
|
When the kernel is running in secure boot mode, we lock down the kernel to
|
|
prevent userspace from modifying the running kernel image. Whilst this
|
|
includes prohibiting access to things like /dev/mem, it must also prevent
|
|
access by means of configuring driver modules in such a way as to cause a
|
|
device to access or modify the kernel image.
|
|
|
|
To this end, annotate module_param* statements that refer to hardware
|
|
configuration and indicate for future reference what type of parameter they
|
|
specify. The parameter parser in the core sees this information and can
|
|
skip such parameters with an error message if the kernel is locked down.
|
|
The module initialisation then runs as normal, but just sees whatever the
|
|
default values for those parameters is.
|
|
|
|
Note that we do still need to do the module initialisation because some
|
|
drivers have viable defaults set in case parameters aren't specified and
|
|
some drivers support automatic configuration (e.g. PNP or PCI) in addition
|
|
to manually coded parameters.
|
|
|
|
This patch annotates drivers in drivers/char/mwave/.
|
|
|
|
Suggested-by: Alan Cox <gnomes@lxorguk.ukuu.org.uk>
|
|
Signed-off-by: David Howells <dhowells@redhat.com>
|
|
---
|
|
drivers/char/mwave/mwavedd.c | 8 ++++----
|
|
1 file changed, 4 insertions(+), 4 deletions(-)
|
|
|
|
diff --git a/drivers/char/mwave/mwavedd.c b/drivers/char/mwave/mwavedd.c
|
|
index 3a3ff2eb6cba..b5e3103c1175 100644
|
|
--- a/drivers/char/mwave/mwavedd.c
|
|
+++ b/drivers/char/mwave/mwavedd.c
|
|
@@ -80,10 +80,10 @@ int mwave_3780i_io = 0;
|
|
int mwave_uart_irq = 0;
|
|
int mwave_uart_io = 0;
|
|
module_param(mwave_debug, int, 0);
|
|
-module_param(mwave_3780i_irq, int, 0);
|
|
-module_param(mwave_3780i_io, int, 0);
|
|
-module_param(mwave_uart_irq, int, 0);
|
|
-module_param(mwave_uart_io, int, 0);
|
|
+module_param_hw(mwave_3780i_irq, int, irq, 0);
|
|
+module_param_hw(mwave_3780i_io, int, ioport, 0);
|
|
+module_param_hw(mwave_uart_irq, int, irq, 0);
|
|
+module_param_hw(mwave_uart_io, int, ioport, 0);
|
|
|
|
static int mwave_open(struct inode *inode, struct file *file);
|
|
static int mwave_close(struct inode *inode, struct file *file);
|