37 lines
1.5 KiB
Diff
37 lines
1.5 KiB
Diff
From: Sameeh Jubran <sameehj@amazon.com>
|
|
Date: Wed, 1 May 2019 16:47:06 +0300
|
|
Subject: [PATCH] net: ena: fix incorrect test of supported hash function
|
|
Origin: https://git.kernel.org/linus/d3cfe7ddbc3dfbb9b201615b7fef8fd66d1b5fe8
|
|
Bug-Debian: https://bugs.debian.org/941291
|
|
|
|
ena_com_set_hash_function() tests if a hash function is supported
|
|
by the device before setting it.
|
|
The test returns the opposite result than needed.
|
|
Reverse the condition to return the correct value.
|
|
Also use the BIT macro instead of inline shift.
|
|
|
|
Fixes: 1738cd3ed342 ("net: ena: Add a driver for Amazon Elastic Network Adapters (ENA)")
|
|
Signed-off-by: Arthur Kiyanovski <akiyano@amazon.com>
|
|
Signed-off-by: Sameeh Jubran <sameehj@amazon.com>
|
|
Signed-off-by: David S. Miller <davem@davemloft.net>
|
|
---
|
|
drivers/net/ethernet/amazon/ena/ena_com.c | 2 +-
|
|
1 file changed, 1 insertion(+), 1 deletion(-)
|
|
|
|
diff --git a/drivers/net/ethernet/amazon/ena/ena_com.c b/drivers/net/ethernet/amazon/ena/ena_com.c
|
|
index b17d435de09f..f9bc0b831a1a 100644
|
|
--- a/drivers/net/ethernet/amazon/ena/ena_com.c
|
|
+++ b/drivers/net/ethernet/amazon/ena/ena_com.c
|
|
@@ -2195,7 +2195,7 @@ int ena_com_set_hash_function(struct ena_com_dev *ena_dev)
|
|
if (unlikely(ret))
|
|
return ret;
|
|
|
|
- if (get_resp.u.flow_hash_func.supported_func & (1 << rss->hash_func)) {
|
|
+ if (!(get_resp.u.flow_hash_func.supported_func & BIT(rss->hash_func))) {
|
|
pr_err("Func hash %d isn't supported by device, abort\n",
|
|
rss->hash_func);
|
|
return -EOPNOTSUPP;
|
|
--
|
|
2.17.1
|
|
|