35 lines
1.2 KiB
Diff
35 lines
1.2 KiB
Diff
From: Sameeh Jubran <sameehj@amazon.com>
|
|
Date: Wed, 1 May 2019 16:47:05 +0300
|
|
Subject: [PATCH] net: ena: fix: Free napi resources when ena_up() fails
|
|
Origin: https://git.kernel.org/linus/b287cdbd1cedfc9606682c6e02b58d00ff3a33ae
|
|
Bug-Debian: https://bugs.debian.org/941291
|
|
|
|
ena_up() calls ena_init_napi() but does not call ena_del_napi() in
|
|
case of failure. This causes a segmentation fault upon rmmod when
|
|
netif_napi_del() is called. Fix this bug by calling ena_del_napi()
|
|
before returning error from ena_up().
|
|
|
|
Fixes: 1738cd3ed342 ("net: ena: Add a driver for Amazon Elastic Network Adapters (ENA)")
|
|
Signed-off-by: Arthur Kiyanovski <akiyano@amazon.com>
|
|
Signed-off-by: Sameeh Jubran <sameehj@amazon.com>
|
|
Signed-off-by: David S. Miller <davem@davemloft.net>
|
|
---
|
|
drivers/net/ethernet/amazon/ena/ena_netdev.c | 1 +
|
|
1 file changed, 1 insertion(+)
|
|
|
|
diff --git a/drivers/net/ethernet/amazon/ena/ena_netdev.c b/drivers/net/ethernet/amazon/ena/ena_netdev.c
|
|
index dbcd58ebd0a9..03244155f74c 100644
|
|
--- a/drivers/net/ethernet/amazon/ena/ena_netdev.c
|
|
+++ b/drivers/net/ethernet/amazon/ena/ena_netdev.c
|
|
@@ -1825,6 +1825,7 @@ static int ena_up(struct ena_adapter *adapter)
|
|
err_setup_tx:
|
|
ena_free_io_irq(adapter);
|
|
err_req_irq:
|
|
+ ena_del_napi(adapter);
|
|
|
|
return rc;
|
|
}
|
|
--
|
|
2.17.1
|
|
|