31 lines
923 B
Diff
31 lines
923 B
Diff
From: Sasha Levin <sasha.levin@oracle.com>
|
|
Date: Thu, 4 Oct 2012 19:56:40 -0400
|
|
Subject: fs: prevent use after free in auditing when symlink following was
|
|
denied
|
|
|
|
commit ffd8d101a3a7d3f2e79deee1e342801703b6dc70 upstream.
|
|
|
|
Commit "fs: add link restriction audit reporting" has added auditing of failed
|
|
attempts to follow symlinks. Unfortunately, the auditing was being done after
|
|
the struct path structure was released earlier.
|
|
|
|
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
|
|
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
|
|
---
|
|
fs/namei.c | 2 +-
|
|
1 file changed, 1 insertion(+), 1 deletion(-)
|
|
|
|
--- a/fs/namei.c
|
|
+++ b/fs/namei.c
|
|
@@ -664,9 +664,9 @@ static inline int may_follow_link(struct
|
|
if (parent->i_uid == inode->i_uid)
|
|
return 0;
|
|
|
|
+ audit_log_link_denied("follow_link", link);
|
|
path_put_conditional(link, nd);
|
|
path_put(&nd->path);
|
|
- audit_log_link_denied("follow_link", link);
|
|
return -EACCES;
|
|
}
|
|
|