114 lines
3.1 KiB
Diff
114 lines
3.1 KiB
Diff
From: Thomas Gleixner <tglx@linutronix.de>
|
|
Date: Thu, 15 Jul 2010 10:29:00 +0200
|
|
Subject: suspend: Prevent might sleep splats
|
|
|
|
timekeeping suspend/resume calls read_persistant_clock() which takes
|
|
rtc_lock. That results in might sleep warnings because at that point
|
|
we run with interrupts disabled.
|
|
|
|
We cannot convert rtc_lock to a raw spinlock as that would trigger
|
|
other might sleep warnings.
|
|
|
|
As a temporary workaround we disable the might sleep warnings by
|
|
setting system_state to SYSTEM_SUSPEND before calling sysdev_suspend()
|
|
and restoring it to SYSTEM_RUNNING afer sysdev_resume().
|
|
|
|
Needs to be revisited.
|
|
|
|
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
|
|
|
|
---
|
|
include/linux/kernel.h | 2 +-
|
|
kernel/power/hibernate.c | 7 +++++++
|
|
kernel/power/suspend.c | 4 ++++
|
|
3 files changed, 12 insertions(+), 1 deletion(-)
|
|
|
|
Index: linux-3.2/include/linux/kernel.h
|
|
===================================================================
|
|
--- linux-3.2.orig/include/linux/kernel.h
|
|
+++ linux-3.2/include/linux/kernel.h
|
|
@@ -356,7 +356,7 @@ extern enum system_states {
|
|
SYSTEM_HALT,
|
|
SYSTEM_POWER_OFF,
|
|
SYSTEM_RESTART,
|
|
- SYSTEM_SUSPEND_DISK,
|
|
+ SYSTEM_SUSPEND,
|
|
} system_state;
|
|
|
|
#define TAINT_PROPRIETARY_MODULE 0
|
|
Index: linux-3.2/kernel/power/hibernate.c
|
|
===================================================================
|
|
--- linux-3.2.orig/kernel/power/hibernate.c
|
|
+++ linux-3.2/kernel/power/hibernate.c
|
|
@@ -284,6 +284,8 @@ static int create_image(int platform_mod
|
|
|
|
local_irq_disable();
|
|
|
|
+ system_state = SYSTEM_SUSPEND;
|
|
+
|
|
error = syscore_suspend();
|
|
if (error) {
|
|
printk(KERN_ERR "PM: Some system devices failed to power down, "
|
|
@@ -311,6 +313,7 @@ static int create_image(int platform_mod
|
|
syscore_resume();
|
|
|
|
Enable_irqs:
|
|
+ system_state = SYSTEM_RUNNING;
|
|
local_irq_enable();
|
|
|
|
Enable_cpus:
|
|
@@ -437,6 +440,7 @@ static int resume_target_kernel(bool pla
|
|
goto Enable_cpus;
|
|
|
|
local_irq_disable();
|
|
+ system_state = SYSTEM_SUSPEND;
|
|
|
|
error = syscore_suspend();
|
|
if (error)
|
|
@@ -470,6 +474,7 @@ static int resume_target_kernel(bool pla
|
|
syscore_resume();
|
|
|
|
Enable_irqs:
|
|
+ system_state = SYSTEM_RUNNING;
|
|
local_irq_enable();
|
|
|
|
Enable_cpus:
|
|
@@ -549,6 +554,7 @@ int hibernation_platform_enter(void)
|
|
goto Platform_finish;
|
|
|
|
local_irq_disable();
|
|
+ system_state = SYSTEM_SUSPEND;
|
|
syscore_suspend();
|
|
if (pm_wakeup_pending()) {
|
|
error = -EAGAIN;
|
|
@@ -561,6 +567,7 @@ int hibernation_platform_enter(void)
|
|
|
|
Power_up:
|
|
syscore_resume();
|
|
+ system_state = SYSTEM_RUNNING;
|
|
local_irq_enable();
|
|
enable_nonboot_cpus();
|
|
|
|
Index: linux-3.2/kernel/power/suspend.c
|
|
===================================================================
|
|
--- linux-3.2.orig/kernel/power/suspend.c
|
|
+++ linux-3.2/kernel/power/suspend.c
|
|
@@ -171,6 +171,8 @@ static int suspend_enter(suspend_state_t
|
|
arch_suspend_disable_irqs();
|
|
BUG_ON(!irqs_disabled());
|
|
|
|
+ system_state = SYSTEM_SUSPEND;
|
|
+
|
|
error = syscore_suspend();
|
|
if (!error) {
|
|
*wakeup = pm_wakeup_pending();
|
|
@@ -181,6 +183,8 @@ static int suspend_enter(suspend_state_t
|
|
syscore_resume();
|
|
}
|
|
|
|
+ system_state = SYSTEM_RUNNING;
|
|
+
|
|
arch_suspend_enable_irqs();
|
|
BUG_ON(irqs_disabled());
|
|
|