52 lines
2.1 KiB
Diff
52 lines
2.1 KiB
Diff
From 62acf66b08656cb7a216aef627c97328a0b17276 Mon Sep 17 00:00:00 2001
|
|
Message-Id: <62acf66b08656cb7a216aef627c97328a0b17276.1601675153.git.zanussi@kernel.org>
|
|
In-Reply-To: <5b5a156f9808b1acf1205606e03da117214549ea.1601675151.git.zanussi@kernel.org>
|
|
References: <5b5a156f9808b1acf1205606e03da117214549ea.1601675151.git.zanussi@kernel.org>
|
|
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
|
|
Date: Tue, 13 Aug 2019 12:30:12 +0200
|
|
Subject: [PATCH 286/333] i2c: exynos5: Remove IRQF_ONESHOT
|
|
Origin: https://www.kernel.org/pub/linux/kernel/projects/rt/4.19/older/patches-4.19.148-rt64.tar.xz
|
|
|
|
[ Upstream commit 4b217df0ab3f7910c96e42091cc7d9f221d05f01 ]
|
|
|
|
The drivers sets IRQF_ONESHOT and passes only a primary handler. The IRQ
|
|
is masked while the primary is handler is invoked independently of
|
|
IRQF_ONESHOT.
|
|
With IRQF_ONESHOT the core code will not force-thread the interrupt and
|
|
this is probably not intended. I *assume* that the original author copied
|
|
the IRQ registration from another driver which passed a primary and
|
|
secondary handler and removed the secondary handler but keeping the
|
|
ONESHOT flag.
|
|
|
|
Remove IRQF_ONESHOT.
|
|
|
|
Reported-by: Benjamin Rouxel <benjamin.rouxel@uva.nl>
|
|
Tested-by: Benjamin Rouxel <benjamin.rouxel@uva.nl>
|
|
Cc: Kukjin Kim <kgene@kernel.org>
|
|
Cc: Krzysztof Kozlowski <krzk@kernel.org>
|
|
Cc: linux-samsung-soc@vger.kernel.org
|
|
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
|
|
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
|
|
---
|
|
drivers/i2c/busses/i2c-exynos5.c | 4 +---
|
|
1 file changed, 1 insertion(+), 3 deletions(-)
|
|
|
|
diff --git a/drivers/i2c/busses/i2c-exynos5.c b/drivers/i2c/busses/i2c-exynos5.c
|
|
index c1ce2299a76e..5c57ecf4b79e 100644
|
|
--- a/drivers/i2c/busses/i2c-exynos5.c
|
|
+++ b/drivers/i2c/busses/i2c-exynos5.c
|
|
@@ -800,9 +800,7 @@ static int exynos5_i2c_probe(struct platform_device *pdev)
|
|
}
|
|
|
|
ret = devm_request_irq(&pdev->dev, i2c->irq, exynos5_i2c_irq,
|
|
- IRQF_NO_SUSPEND | IRQF_ONESHOT,
|
|
- dev_name(&pdev->dev), i2c);
|
|
-
|
|
+ IRQF_NO_SUSPEND, dev_name(&pdev->dev), i2c);
|
|
if (ret != 0) {
|
|
dev_err(&pdev->dev, "cannot request HS-I2C IRQ %d\n", i2c->irq);
|
|
goto err_clk;
|
|
--
|
|
2.17.1
|
|
|