From 0b2ecf29a3e8d184251a5103ef5bf728da1b45d5 Mon Sep 17 00:00:00 2001 Message-Id: <0b2ecf29a3e8d184251a5103ef5bf728da1b45d5.1601675151.git.zanussi@kernel.org> In-Reply-To: <5b5a156f9808b1acf1205606e03da117214549ea.1601675151.git.zanussi@kernel.org> References: <5b5a156f9808b1acf1205606e03da117214549ea.1601675151.git.zanussi@kernel.org> From: Sebastian Andrzej Siewior Date: Tue, 27 Mar 2018 16:24:15 +0200 Subject: [PATCH 034/333] dm rq: remove BUG_ON(!irqs_disabled) check Origin: https://www.kernel.org/pub/linux/kernel/projects/rt/4.19/older/patches-4.19.148-rt64.tar.xz In commit 052189a2ec95 ("dm: remove superfluous irq disablement in dm_request_fn") the spin_lock_irq() was replaced with spin_lock() + a check for disabled interrupts. Later the locking part was removed in commit 2eb6e1e3aa87 ("dm: submit stacked requests in irq enabled context") but the BUG_ON() check remained. Since the original purpose for the "are-irqs-off" check is gone (the ->queue_lock has been removed) remove it. Cc: Keith Busch Cc: Mike Snitzer Signed-off-by: Sebastian Andrzej Siewior --- drivers/md/dm-rq.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/md/dm-rq.c b/drivers/md/dm-rq.c index 9fde174ce396..e6bffe4b9439 100644 --- a/drivers/md/dm-rq.c +++ b/drivers/md/dm-rq.c @@ -689,7 +689,6 @@ static void dm_old_request_fn(struct request_queue *q) /* Establish tio->ti before queuing work (map_tio_request) */ tio->ti = ti; kthread_queue_work(&md->kworker, &tio->work); - BUG_ON(!irqs_disabled()); } } -- 2.17.1