modification based on comments

Move initialization
Fix return value for pjsua_set_snd_dev2() with no sound device option
2023-12-26 15:02:37 +07:00 · 2023-12-26 13:42:44 +07:00 · 2023-12-22 17:49:20 +07:00
1 changed files with 3 additions and 2 deletions
--- a/pjsip/src/pjsua-lib/pjsua_aud.c
+++ b/pjsip/src/pjsua-lib/pjsua_aud.c
@ -2228,7 +2228,7 @@ PJ_DEF(pj_status_t) pjsua_set_snd_dev2(const pjsua_snd_dev_param *snd_param)
    unsigned alt_cr_cnt = 1;
    unsigned alt_cr[] = {0, 44100, 48000, 32000, 16000, 8000};
    unsigned i;
-    pj_status_t status = -1;
+    pj_status_t status = PJ_SUCCESS;
    unsigned orig_snd_dev_mode = pjsua_var.snd_mode;

    PJ_ASSERT_RETURN(snd_param, PJ_EINVAL);
@ -2267,7 +2267,8 @@ PJ_DEF(pj_status_t) pjsua_set_snd_dev2(const pjsua_snd_dev_param *snd_param)
        PJSUA_UNLOCK();
        PJ_LOG(4, (THIS_FILE, "No sound device, mode setting is ignored"));
        if (!pjsua_var.no_snd)
-            pjsua_set_no_snd_dev();
+            PJ_ASSERT_RETURN(pjsua_set_no_snd_dev(), PJ_ENOTFOUND);
+
        pj_log_pop_indent();
        return status;
    }
Author	SHA1	Message	Date
Riza Sulistyo	f817bacb73	modification based on comments	2023-12-26 15:02:37 +07:00
Riza Sulistyo	537640dea9	Move initialization	2023-12-26 13:42:44 +07:00
Riza Sulistyo	0ddd6b94c2	Fix return value for pjsua_set_snd_dev2() with no sound device option	2023-12-22 17:49:20 +07:00